Work around for guest VM password reset failure (PR/2084) - #2155
Closed
krissterckx wants to merge 1 commit into
Closed
Work around for guest VM password reset failure (PR/2084)#2155krissterckx wants to merge 1 commit into
krissterckx wants to merge 1 commit into
Conversation
| password = CsPassword("vmpassword", config) | ||
| password.process() | ||
| # TODO fix the line below | ||
| # password = CsPassword("vmpassword", config) |
Contributor
There was a problem hiding this comment.
I don't feel confident this will be backwards compatible. We are now not configuring the vm with a password.
Contributor
There was a problem hiding this comment.
@DaanHoogland This block of code also fails on Native ACS setups. Please refer my latest comment on this PR.
Contributor
|
This is the error we see with the CsPassword class in the configure.py systemvm patch script (cloud.log on VR): 2017-06-20 12:28:47,015 configure.py main:943 Configuring Guest Network Here is an example cloud.log in a VR on a Native ACS setup: |
Member
|
@krissterckx @prashanthvarma if @blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Contributor
|
@rhtyd To give you more context, we started seeing password reset failures on our Nuage VSP setups due to missing iptable rules on the VR, which are not being configured when we are not using specific services being provided by the VR (e.g. LB, setting iptables_change=True). Thus, we are adding the iptables_change=True flag to the CsPassword block as we use VR as the password reset service provider. We found out that CsPassword block always fails due to import error (Note: even for Native ACS setups, refer the above attached cloud.log), which we tried to fix and ran into other issues with that block of code. Thus, we don't think that any of the functionality is being affected by this block of code. Note: We might be wrong, as we didn't test all the scenarios, and have no background on impact of this block of code on the overall functionality. Anyhow, someone should fix and analyze the impact of this block on the functionality. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-782 |
Contributor
Author
|
Hi so just to be very clear : password = CsPassword("vmpassword", config) can never really work for two reasons
I can leave out the comment lines and the TODO statement in the PR obviously but i wanted the author/expert eyes to look at this before doing that. Kris |
Member
|
@blueorangutan test matrix |
|
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests |
Contributor
|
I think it is better to revert PR #2084 |
|
Trillian test result (tid-1177)
|
|
Trillian test result (tid-1176)
|
|
Trillian test result (tid-1178)
|
Member
|
@remibergsma can you please review? |
Contributor
Author
|
I recommend closing this PR and reverting #2084 instead i.e give PR/2048 more soak time in 4.11. I want to support qualifying it in the upcoming release. It is breaking VR-provided Guest DNS for SDN providers also, as we found today. Best, |
|
Yes, think we need rever #2084 and release another RC of 4.10.
在2017年06月23 03时42分, "Kris Sterckx"<notifications@github.com>写道:
I recommend closing this PR and reverting #2084 instead i.e give PR/2048 more soak time in 4.11. I want to support qualifying it in the upcoming release.
It is breaking VR-provided Guest DNS for SDN providers also, as we found today.
Best,
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
Closing this PR as #2084 was reverted from RC5 -> RC6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… providers.