Passwd speedup - #2084
Merged
Merged
Conversation
- do not keep passwords in databag (/etc/cloudstack/vmpasswd.json) - process only the password we get in (vm_password.json) from mgt server - lookup the correct passwd server instead of adding passwd to all of them Example: - 4 tiers and 199 VMs running - Start vm 200 would cause new passwd from vm_password.json (1) to be merged with /etc/cloudstack/vmpasswd.json (199) - A curl command was exected foreach password (200) foreach tier (4) resulting in 800 calls - In fact, since passwds are never cleaned it could very well be even more as the ip address was the key in the json file so until the ip address was reused the original password would remain and be sent to passwd server every time another vm starts. - This took ~40 seconds Now we just figure out the right tier and only process the new password resulting in a single curl call. - takes 0,03 seconds!
Contributor
Author
|
@karuturi I don't think it needs CI (yet), it needs testing and review! I don't think ci can assess performance issues, unless with a lot of compute power. |
Closed
Contributor
Author
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
remibergsma
approved these changes
May 12, 2017
remibergsma
left a comment
Contributor
There was a problem hiding this comment.
Runs fine in Cosmic for over a year. LGTM
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-713 |
Contributor
Author
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1083)
|
Contributor
Author
|
/marvin/tests/smoke/test_privategw_acl.py is known not to work, we need to find time to work on that one, but it is surely unrelated. |
karuturi
added a commit
to karuturi/cloudstack
that referenced
this pull request
Jun 26, 2017
* 4.9: Revert "Merge pull request apache#2084 from shapeblue/passwd-speedup"
Member
|
This was reverted, any plans to work on it @DaanHoogland ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.