Fix insertion location of <template> for declarative shadow roots#12666
Open
shannonbooth wants to merge 2 commits into
Open
Fix insertion location of <template> for declarative shadow roots#12666shannonbooth wants to merge 2 commits into
shannonbooth wants to merge 2 commits into
Conversation
shannonbooth
commented
Jul 9, 2026
Contributor
|
Thanks! Any reason this is marked as a draft? |
Recomputing the adjusted insertion location after <template> was pushed onto the stack of open elements caused it to be inserted into itself for two templates in a row. Fix by reusing the location computed before <template> is created.
Member
Author
Due to: #12666 (comment), I've pushed a commit with what I mean but that, just double checking it now. I think I will need to fill out the template and that type of thing, though I think this is the intent of the spec |
Member
Author
|
ok done! |
noamr
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recomputing the adjusted insertion location after
<template>was pushedonto the stack of open elements caused it to be inserted into itself for
two templates in a row. Fix by reusing the location computed before
<template>is created.NB: though this area was changed around recently in #12624, this issue existed before that.
(See WHATWG Working Mode: Changes for more details.)
/parsing.html ( diff )