IADK: fix module configuration sizing and error handling - #11118
Open
abonislawski wants to merge 3 commits into
Open
IADK: fix module configuration sizing and error handling#11118abonislawski wants to merge 3 commits into
abonislawski wants to merge 3 commits into
Conversation
Reject malformed initialization data before deriving the extended module configuration. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Stop module initialization when the external factory reports a creation error. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Use the matching output pin type when validating compound configuration sizes. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
requested review from
dbaluta,
kv2019i,
lbetlej and
mmaka1
as code owners
August 25, 2026 06:32
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens robustness of the IADK module instantiation path by validating module configuration IPC payloads before use, correctly sizing compound configuration blobs, and ensuring module factory failures do not lead to using an invalid module instance.
Changes:
- Fix compound INIT_INSTANCE size calculation by using
OutputPinFormatsizing for output pins. - Reject unparsable module configuration messages during
SystemAgent::CheckIn. - Stop proceeding after module factory creation failures (return error instead of continuing initialization).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/audio/module_adapter/iadk/system_agent.cpp | Adds config parse validation and checks factory creation result before continuing module initialization. |
| src/audio/module_adapter/iadk/module_initial_settings_concrete.cpp | Corrects compound configuration size computation for output pin formats. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+90
to
+96
| ErrorCode::Type error; | ||
| IoPinsInfo pins_info; | ||
| const dsp_fw::DwordArray& cfg_ipc_msg = | ||
| *reinterpret_cast<const dsp_fw::DwordArray*>(obfuscated_mod_cfg); | ||
| ModuleInitialSettingsConcrete settings(cfg_ipc_msg); | ||
| if (!settings.IsParsable()) | ||
| return -EINVAL; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutputPinFormatfor output pins.SystemAgent::CheckIn.