Add go mod download before egressip make build - #29
Merged
Conversation
openshift-tests-private PR #30082 removed the update-origin target from the build dependency chain. That target populated GOMODCACHE with the openshift/origin module before patch-bindata ran. Without it, patch-bindata tries to chmod a file in the module cache that has not been downloaded yet, failing with "No such file or directory" (OCPQUAL-31 side-effect). Run go mod download explicitly before make build to ensure the module cache is populated, restoring the previous behaviour. Co-authored-by: Cursor <cursoragent@cursor.com>
tusharjadhav3302
requested review from
chenwng,
dlaw4608,
ekuris-redhat,
eshulman2,
gryf,
imatza-rh,
mandre,
stephenfin and
winiciusallan
as code owners
August 1, 2026 13:10
IlanZuckerman
approved these changes
Aug 2, 2026
IlanZuckerman
left a comment
There was a problem hiding this comment.
We can approve this in order to unblock the CI failures, but IMO, the long term fix should be upstream Makefile fix and plan to delete this workaround .
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekuris-redhat, IlanZuckerman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workaround for
openshift-tests-privatebuild failure caused byPR #30082 removing the
update-origintarget from thebuilddependency chain.
Problem
Since Jul 30, all RHOSO periodic jobs with egressip_tests fail:
The
update-originMakefile target previously rango mod downloadto populate
GOMODCACHEwith theopenshift/originmodule beforepatch-bindatatried tochmoda file in it. Without that step,the module cache is empty when
make buildruns.Fix
Add an explicit
go mod downloadtask beforemake buildinrun_egressip_tests.yml. This restores the previous behaviourwithout modifying the upstream Makefile.
Impact
release-4.22,release-4.23,release-5.0branchesRelated
Made with Cursor