New Jython auto-completion pulldown filled wrongly

[haesleinhuepf]

Hi @acardona and @tferr ,

I just tested the new Jython auto-completion (on @tferr branch linked in #51 ) not sure if this branch is the issue, but when using IJ.getImage() the auto-completion looks like this:

Let me know if I can help tracing down this bug.

[tferr]

@haesleinhuepf, just to clarify:
you get this with script-editor 0.5.10-SNAPSHOT from https://github.com/tferr/Script_Editor/tree/autocompletion-vars and master from https://github.com/fiji/jython-autocompletion? I cannot reproduce it. Works OK for me.

[tferr]

@haesleinhuepf, I can reproduce it now after clearing up maven's cache. Please don't think I am ruthless. I promise you I did test things :). I must have broke something last minute. Oh boy, I hate working across repositories. It is painful. Do let me know if you have any tips..

[acardona]

Don’t merge, rebase—that tends to do it for me. Albert

[tferr]

@haesleinhuepf ,
Thanks a lot for noticing the bug. Should be fixed now with scijava/script-editor-jython@9a83c9f. TLDR; While back (before @acardona's mechanism), we had implemented 'Fuzzy search' for the completion list. I remembered it only last minute and brought it back 'last minute'. Turns out, it needed some patching. It is working now. Please give it a go, and let me know if you notice something else.

To anyone new to this discussion, you will need to use script-editor 0.5.10-SNAPSHOT from https://github.com/tferr/Script_Editor/tree/autocompletion-vars and master from https://github.com/fiji/jython-autocompletion. I am attaching both artifacts below, in case it helps.

artifacts.zip

Also, a reminder that I will need someone with write privileges to merge #51 AND release script-editor 0.5.10. Without it I won't be able to push the jython-autocompletion jar to the Java8 update site.
If you guys provide me write access, I can do it.

(Also, I cannot close or tag this issue, so I will leave it open :))

[haesleinhuepf]

Hey @tferr ,

I just downloaded the recent source of your script-editor branch and jhython-autocompletion but the bug appears still there:

I made sure that this commit is in:

Is there anythin else I need to update?

[imagejan]

@tferr wrote:

If you guys provide me write access, I can do it.

I can't take the responsibility of merging #51 (I didn't test myself yet), but I granted you write access to this repository, so you can take action yourself (hope that's alright, @ctrueden).

@tferr it would be nice if you also document your role in the developers section of pom.xml.

Thanks for your work!

[tferr]

@haesleinhuepf, Bummer. I had tested the artifacts above on a virgin installation with no issues. Will look

[tferr]

@haesleinhuepf, I understand now. It is all in the MCVE!! So my go-to testing snippet is:

from ij import ImagePlus
imp = ImagePlus()
imp.

Only now I see that your report uses a static call from ij.IJ:

from ij import IJ
imp = IJ.getImage()
imp.

So, good news: using the former I fixed a different bug yesterday 😄 Bad news: You are right, the latter is still broken.
Meanwhile, Can you please confirm that the ImagePlus() constructor completion works for you?I will look at the static completion tonight.
Thanks for the double bug report 😉

[tferr]

@haesleinhuepf, please push the latest changes from https://github.com/fiji/jython-autocompletion. The issue with the static completions is fixed.

Could you please test it further and check that everything works OK on your end?

@tferr it would be nice if you also document your role in the developers section of pom.xml.

@imagejan, will do. FYI: the changes with #51 affect only two classes:

• ClassUtil: Added methods for generating completions with functional hyperlinks (Could be used in the future by other languages)
• CompletionText: Convenience class to store data needed to generate a completion (replacement text, class name, summary, etc.)
  I will try to squash the multiple commits there into something more tractable.

[haesleinhuepf]

Hey @tferr ,

both bugs are fixed, indeed! Thanks for investing your time! :-)

Just follow up bug report, do you know why the content of these two pulldowns (corresponding both examples discussed above) is different? It may not be an issue of the auto-completion. I'm just wondering: at least imp.getProcessor() should show up in both, or?

Thanks again!

Cheers,
Robert

[haesleinhuepf]

Is it possible that in the first case it only lists static methods?

[acardona]

Indeed looks like the first case lists only static methods. That’s a bug. Means it’s using the regex shortcuts and not the full AST traversal to discover the type—a regression, I think.

[tferr]

Bummer. Regression is likely. I don't recall noticing it when I took over. I will first look if the issue was already present in Albert's last commit and track it from there.

[tferr]

@acardona: on the first case listing only static methods: The regression is already present before my commits. It is already present on your last change (https://github.com/fiji/jython-autocompletion/tree/4ed0695f41798fddfb03a3763e3c87358defdd66). Would be great if you (or @haesleinhuepf) could look into it.
Meanwhile, I could try to working on releasing the new script-editor version. That will make things easier for everybody.

NB: I won't have much more time to work on this in the immediate future. If your time is also tight, I vote releasing things as they are (I am assuming that we have not broken anything for you @haesleinhuepf, correct?), and go through the improvements later on. Despite this issue, the current completion is quite functional, would be a pity to delay it further.