The router can have a max bid price by currency - #136
Open
daedric wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Any comment ? |
Contributor
Author
|
const added |
|
Hello, The idea behind this Pull Request is good. Concerning the implementation, I was suggesting using the CurrencyPool class rather than std::vector. CurrencyPool has a getAvailable member function which you can use to retrieve the available amount corresponding to the given CurrencyCode. Even though it consists of a loop versus a map lookup, I don't think it will impact performances. What do you think ? |
Contributor
Author
|
I agree on the performances. I currently don't have the time to do the update. Thanks for the review |
jeremybarnes
referenced
this pull request
in datacratic/rtbkit
Sep 26, 2014
…iptions Less inline code in value descriptions (TRIVIAL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.