Skip to content

Fix dict idempotency missing-key detection from issue #8390 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ritofactory-dev wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix dict idempotency missing-key detection from issue #8390 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion aws_lambda_powertools/utilities/idempotency/persistence/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ def _get_hashed_idempotency_key(self, data: dict[str, Any]) -> str | None:

@staticmethod
def is_missing_idempotency_key(data) -> bool:
if isinstance(data, (tuple, list, dict)):
if isinstance(data, dict):
return all(x is None for x in data.values())
elif isinstance(data, (tuple, list)):
return all(x is None for x in data)
elif isinstance(data, (int, float, bool)):
return False
Expand Down
10 changes: 7 additions & 3 deletions tests/functional/idempotency/_boto3/test_idempotency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,10 @@ def test_is_missing_idempotency_key():
assert BasePersistenceLayer.is_missing_idempotency_key((None, None))
# GIVEN a dict of Nones THEN is_missing_idempotency_key is True
assert BasePersistenceLayer.is_missing_idempotency_key({None: None})
# GIVEN a dict with non-None keys and all None values THEN is_missing_idempotency_key is True
assert BasePersistenceLayer.is_missing_idempotency_key({"user": None, "order": None})
# GIVEN a dict with a non-None value THEN is_missing_idempotency_key is False
assert BasePersistenceLayer.is_missing_idempotency_key({"user": "123", "order": None}) is False

# GIVEN True THEN is_missing_idempotency_key is False
assert BasePersistenceLayer.is_missing_idempotency_key(True) is False
Expand Down Expand Up @@ -1092,7 +1096,7 @@ def test_default_no_raise_on_missing_idempotency_key(
@pytest.mark.parametrize(
"idempotency_config",
[
{"use_local_cache": False, "event_key_jmespath": "[body, x]"},
{"use_local_cache": False, "event_key_jmespath": "{user: user, order: order}"},
],
indirect=True,
)
Expand All @@ -1104,9 +1108,9 @@ def test_raise_on_no_idempotency_key(
persistence_store.configure(idempotency_config)
persistence_store.raise_on_no_idempotency_key = True
assert persistence_store.use_local_cache is False
assert "body" in persistence_store.event_key_jmespath
assert "user" in persistence_store.event_key_jmespath

# WHEN getting the hashed idempotency key for an event with no `body` key
# WHEN getting the hashed idempotency key for an event with neither projected key
with pytest.raises(IdempotencyKeyError) as excinfo:
persistence_store._get_hashed_idempotency_key({})

Expand Down