Drop Node v0.8 and add io.js - #4
Conversation
|
ping @simov, hopefully all these builds pass, Travis is slow today. |
Maybe this is more trouble than it's worth. I forgot how much these tests sucked. |
|
@simov Build passes now, but it will probably break again in the future. How can we make these tests more robust? A couple of ideas:
|
…into fix/drop-node-0.8
|
Only test for a few specific headers might be the better option. Btw why not put the contents of the |
|
Sure, you could delete that header with a function that returns |
|
@nylen I just converted to 2 space indentation to mach the rest of projects in this organization. I decided to leave |
|
Fine with me! |
|
🎉 tests are passing |
As requested at #3 (comment).
The multiple
requestversions are tested to maintain backwards compatibility with older versions. I was seeing some strange issues and this seemed like a good health check of both libraries. I've updated the version numbers here, we could probably remove a few more from the list.