Skip to content

Drop Node v0.8 and add io.js - #4

Merged
simov merged 15 commits into
masterfrom
fix/drop-node-0.8
May 18, 2015
Merged

Drop Node v0.8 and add io.js#4
simov merged 15 commits into
masterfrom
fix/drop-node-0.8

Conversation

@nylen

@nylen nylen commented May 5, 2015

Copy link
Copy Markdown
Member

As requested at #3 (comment).

The multiple request versions are tested to maintain backwards compatibility with older versions. I was seeing some strange issues and this seemed like a good health check of both libraries. I've updated the version numbers here, we could probably remove a few more from the list.

@nylen nylen changed the title Fix/drop node 0.8 Drop Node v0.8 and add io.js May 5, 2015
@nylen

nylen commented May 5, 2015

Copy link
Copy Markdown
Member Author

ping @simov, hopefully all these builds pass, Travis is slow today.

@nylen nylen mentioned this pull request May 13, 2015
@nylen

nylen commented May 13, 2015

Copy link
Copy Markdown
Member Author

You said:

Also I'm not sure why do we need to test against so many versions of request.

Maybe this is more trouble than it's worth. I forgot how much these tests sucked.

@nylen
nylen force-pushed the fix/drop-node-0.8 branch from d810479 to 8bb8a48 Compare May 13, 2015 18:06
@nylen

nylen commented May 13, 2015

Copy link
Copy Markdown
Member Author

@simov Build passes now, but it will probably break again in the future. How can we make these tests more robust? A couple of ideas:

  • Only test for a few specific headers
  • Record requests and responses for each Node/io.js and request version, and store them separately (how to automate this?)

@simov

simov commented May 14, 2015

Copy link
Copy Markdown
Member

Only test for a few specific headers might be the better option. Btw why not put the contents of the maybeTransferEncodingChunked function into lib/fixHeader? If I'm understanding correctly you are already doing some header manipulations there.

@nylen

nylen commented May 17, 2015

Copy link
Copy Markdown
Member Author

Sure, you could delete that header with a function that returns null. Then it wouldn't be checked, which is probably OK.

@simov

simov commented May 18, 2015

Copy link
Copy Markdown
Member

@nylen I just converted to 2 space indentation to mach the rest of projects in this organization. I decided to leave maybeTransferEncodingChunked as it is because it is used only for a single and specific requests, and can't blend that well with the rest of the code in lib. If you are OK with the indentation change, we can merge it and resolve #3 after that.

@nylen

nylen commented May 18, 2015

Copy link
Copy Markdown
Member Author

Fine with me!

@simov

simov commented May 18, 2015

Copy link
Copy Markdown
Member

🎉 tests are passing

simov added a commit that referenced this pull request May 18, 2015
@simov
simov merged commit 7ff259e into master May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants