Skip to content

Translate Design Principles - #60

Merged
halian-vilela merged 6 commits into
reactjs:masterfrom
moiseshilario:translate-design-principles
Feb 18, 2019
Merged

Translate Design Principles#60
halian-vilela merged 6 commits into
reactjs:masterfrom
moiseshilario:translate-design-principles

Conversation

@moiseshilario

Copy link
Copy Markdown
Contributor

This PR references issue #1 translating the Design Principle doc

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 10, 2019
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiseshilario
Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
@glaucia86 glaucia86 added needs +1 Needs another approval before merging needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed needs +1 Needs another approval before merging labels Feb 10, 2019
glaucia86 and others added 2 commits February 11, 2019 17:42
Co-Authored-By: moiseshilario <moiseshilariu@gmail.com>
@moiseshilario

moiseshilario commented Feb 11, 2019

Copy link
Copy Markdown
Contributor Author

@glaucia86 @converge Obrigado pelas sugestões e correções, a maioria delas foram aplicadas e o PR foi atualizado. Repondi alguns dos comentários, pois precisamos entrar em acordo com alguns termos. Fora isso, tudo certo para um Review de novo.

@eduardomoroni eduardomoroni added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 12, 2019
@cezaraugusto cezaraugusto self-assigned this Feb 14, 2019
glaucia86
glaucia86 previously approved these changes Feb 14, 2019

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiseshilario

LGTM 👍
Muito obrigada pela sua contribuição!

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed 💪 long page - more than 100 lines Long page labels Feb 14, 2019
glaucia86
glaucia86 previously approved these changes Feb 14, 2019

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiseshilario

LGTM 👍

Muito obrigada pela sua contribuição. :)

cc: @fjoshuajr @cezaraugusto @eduardomoroni só aprovar. Mais do que revisado.

@halian-vilela
halian-vilela self-requested a review February 15, 2019 00:04

@halian-vilela halian-vilela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blz! Solicitei algumas pequenas modificações de detalhes que melhorariam a compreensão.

Por favor, revise e faça suas consideraçõe, se necessário, e logo sua contribuição será aprovada!

Obrigado!

Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
Comment thread content/docs/design-principles.md Outdated
@halian-vilela halian-vilela added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 15, 2019
Co-Authored-By: moiseshilario <moiseshilariu@gmail.com>
@moiseshilario
moiseshilario dismissed stale reviews from glaucia86 via 6be8e95 February 18, 2019 14:01
@moiseshilario

Copy link
Copy Markdown
Contributor Author

@halian-vilela Muito obrigado pelas correções! PR foi corrigido e atualizado. Esperando review e aprovação.

@halian-vilela
halian-vilela merged commit 94c077a into reactjs:master Feb 18, 2019
@halian-vilela halian-vilela added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 18, 2019
devin-ai-integration Bot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@moiseshilario 

Ótimo! Como os outros revisores já haviam aprovado, estou fazendo o merge! 

Obrigado pela contribuição! 

CC: @glaucia86 @converge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌐 translated Translation is completed for this page

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants