Skip to content

Translate Hello World - #57

Merged
glaucia86 merged 11 commits into
reactjs:masterfrom
rafael-vitor:hello-world
Feb 12, 2019
Merged

Translate Hello World#57
glaucia86 merged 11 commits into
reactjs:masterfrom
rafael-vitor:hello-world

Conversation

@rafael-vitor

@rafael-vitor rafael-vitor commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 10, 2019
tibuurcio
tibuurcio suggested changes Feb 10, 2019
View reviewed changes

@tibuurcio tibuurcio left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rafael-vitor, thanks for taking the time to help with translation. The hello-world page is such an important one!

I've made some reviews mostly based on syntax. Also, we shouldn't translate anchor links as per the universal styleguide.

Please let me know if you think anything should be different. Cheers 馃槃

Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
@tibuurcio tibuurcio added the needs author response Changes requested needing author's input label Feb 10, 2019
glaucia86
glaucia86 suggested changes Feb 10, 2019
View reviewed changes

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafael-vitor

Algumas altera莽玫es a serem feitas. Pedimos que fa莽a os ajustes e logo iremos aprovar a sua contribui莽茫o.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradu莽茫o e enfim, aprovar o seu PR. Muito obrigada!

Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
Comment thread content/docs/hello-world.md Outdated
@glaucia86 glaucia86 removed the needs review A pull request ready to be reviewed label Feb 10, 2019
@glaucia86

glaucia86 commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

@rafael-vitor

Algumas altera莽玫es a serem feitas. Pedimos que fa莽a os ajustes e logo iremos aprovar a sua contribui莽茫o.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradu莽茫o e enfim, aprovar o seu PR. Muito obrigada!

Assim que voc锚 concluir as suas mudan莽as, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribui莽茫o! 馃槃

tibuurcio and others added 10 commits February 10, 2019 11:30
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
2cbc076 
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
c23fe78 
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
be484a1 
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
43bd21c 
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
2b44323 
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@glaucia86 @rafael-vitor
Update content/docs/hello-world.md
d2e6408 
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@glaucia86 @rafael-vitor
Update content/docs/hello-world.md
c97691a 
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@glaucia86 @rafael-vitor
Apply suggestions from code review
57afdd4 
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@rafael-vitor
FIx duplicated line
cadb27f
@rafael-vitor
Add missing >
297eaf9
@rafael-vitor

rafael-vitor commented Feb 10, 2019

Copy link
Copy Markdown
Contributor Author

Ol谩 @glaucia86

As altera莽玫es solicitadas foram realizadas.

@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@rafael-vitor

rafael-vitor commented Feb 11, 2019

Copy link
Copy Markdown
Contributor Author

@glaucia86 Acho que n茫o posso alterar a label por que n茫o sou contribuidor 馃槵

@tibuurcio tibuurcio added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
glaucia86
glaucia86 approved these changes Feb 12, 2019
View reviewed changes

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafael-vitor
LGTM 馃憤
Queremos agradecer pela sua excelente contribui莽茫o! Muito obrigada!

@glaucia86
glaucia86 merged commit 1cafa29 into reactjs:master Feb 12, 2019
@glaucia86 glaucia86 added 馃寪 translated Translation is completed for this page and removed feedback addressed labels Feb 12, 2019
@rafael-vitor
rafael-vitor deleted the hello-world branch February 12, 2019 10:31
devin-ai-integration Bot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@rafael-vitor @glaucia86
Translate Hello World (reactjs#57)
bbadcbd 
* Hello world page translation

* Update content/docs/hello-world.md

Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>

* Update content/docs/hello-world.md

Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>

* Update content/docs/hello-world.md

Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>

* Update content/docs/hello-world.md

Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>

* Update content/docs/hello-world.md

Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>

* Update content/docs/hello-world.md

Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>

* Update content/docs/hello-world.md

Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>

* Apply suggestions from code review

Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>

* FIx duplicated line

* Add missing >
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@glaucia86 glaucia86 glaucia86 approved these changes
@tibuurcio tibuurcio tibuurcio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

馃寪 translated Translation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rafael-vitor @glaucia86 @tibuurcio @fjoshuajr