Skip to content

Translate state and lifecycle page - #39

Merged
glaucia86 merged 11 commits into
reactjs:masterfrom
jhonmike:state-and-lifecycle
Feb 11, 2019
Merged

Translate state and lifecycle page#39
glaucia86 merged 11 commits into
reactjs:masterfrom
jhonmike:state-and-lifecycle

Conversation

@jhonmike

@jhonmike jhonmike commented Feb 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

#1

Sections:

  • Intro to State and Lifecycle
  • Converting a Function to a Class
  • Adding Local State to a Class
  • Adding Lifecycle Methods to a Class
  • Using State Correctly
  • The Data Flows Down

@fjoshuajr fjoshuajr added the work in progress Author opened the pull-request but it's still being worked on label Feb 9, 2019
@fjoshuajr fjoshuajr changed the title Translate state and lifecycle page [WIP] Translate state and lifecycle page Feb 9, 2019
@jhonmike jhonmike changed the title [WIP] Translate state and lifecycle page Translate state and lifecycle page Feb 9, 2019
@tibuurcio

tibuurcio commented Feb 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @jhonmike, thank you for taking the time to contribute to translating the docs 馃憤

Just to give you a heads up, I think as per #4 we shouldn't translate state to estado since it refers to such an important concept in React.

In some other PR's I'm also seeing it like: estado (state)

@cezaraugusto cezaraugusto added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 9, 2019
@cezaraugusto

cezaraugusto commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

@tibuurcio what do you think about using estado (_state_)? I personally like this way

@tibuurcio

tibuurcio commented Feb 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@cezaraugusto I personally think leaving just state is better, but I don't think estado (state) is bad in any way. Also, you have a lot more experience in this than I do 馃槅.

Maybe I'm just used to see it being written as state in english articles that it feels strange to translate probably the biggest concept (along with props) in React's API.

@jhonmike

jhonmike commented Feb 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Also I was thinking, I think it could be state only, similar to props @cezaraugusto @tibuurcio

@halian-vilela

halian-vilela commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

@tibuurcio what do you think about using estado (_state_)? I personally like this way

I think that state can represent two different things and should be treated acordingly...

When representing the current state of the application, as a snapshot in time, I don't think it loses semantic value if we translate it to "estado".

I guess it only loses value when it's talking about state as a property of react and all that its concerned with. In this case I think we could use it without translation.

Makes sense?

@tibuurcio

tibuurcio commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

@halian-vilela It makes sense, indeed :)

LeoMosiah
LeoMosiah suggested changes Feb 10, 2019
View reviewed changes
Comment thread content/docs/state-and-lifecycle.md Outdated
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
halian-vilela
halian-vilela previously approved these changes Feb 10, 2019
View reviewed changes

@halian-vilela halian-vilela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
S贸 mudar essa 煤ltima coisinhas sobre o g锚nero das fun莽玫es.

Comment thread content/docs/state-and-lifecycle.md Outdated
@jhonmike

jhonmike commented Feb 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Esse force foi apenas um update da master com um --rebase no final ;)

cezaraugusto
cezaraugusto previously requested changes Feb 11, 2019
View reviewed changes

@cezaraugusto cezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obrigado @jhonmike! pedi uns ajustes: um erro de ortografia e para capitalizar as palavras dos t铆tulos, como original. De resto t谩 贸timo pra mim.

Comment thread content/docs/state-and-lifecycle.md Outdated
Comment thread content/docs/state-and-lifecycle.md Outdated
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed feedback addressed labels Feb 11, 2019
@cezaraugusto cezaraugusto removed the needs review A pull request ready to be reviewed label Feb 11, 2019
@WendellAdriel WendellAdriel added needs +1 Needs another approval before merging feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
glaucia86
glaucia86 approved these changes Feb 11, 2019
View reviewed changes

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhonmike

LGTM 馃憤
Queremos agradecer pela sua excelente contribui莽茫o! Muito obrigada!

@glaucia86
glaucia86 dismissed cezaraugusto鈥檚 stale review February 11, 2019 16:44

WendellAdriel e eu j谩 realizamos o review desse PR e as altera莽玫es solicitadas j谩 foram feitas.

@glaucia86
glaucia86 merged commit afbb698 into reactjs:master Feb 11, 2019
@glaucia86 glaucia86 added 馃寪 translated Translation is completed for this page and removed feedback addressed needs +1 Needs another approval before merging labels Feb 11, 2019
devin-ai-integration Bot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
Jhon Mike @glaucia86
Translate state and lifecycle page (reactjs#39)
bf098f8 
* translated the first part of the state and life cycle doc

* translated section covert function for a class

* translated section adding local state to class

* translated section adding lifecycle methods to a class

* translated section using state correctly

* translated section the date flows down

fix

* Revert internal link translations

* treating according to its context

* Update content/docs/state-and-lifecycle.md

Co-Authored-By: jhonmike <developer@jhonmike.com.br>

* Update content/docs/state-and-lifecycle.md

Co-Authored-By: jhonmike <developer@jhonmike.com.br>

* leaving title in capital
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers
@LeoMosiah LeoMosiah LeoMosiah requested changes
@glaucia86 glaucia86 glaucia86 approved these changes
@WendellAdriel WendellAdriel WendellAdriel approved these changes
@halian-vilela halian-vilela halian-vilela left review comments
@cezaraugusto cezaraugusto cezaraugusto left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

馃寪 translated Translation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jhonmike @tibuurcio @cezaraugusto @halian-vilela @glaucia86 @WendellAdriel @LeoMosiah @fjoshuajr