Skip to content

Special props translation - #28

Merged
fjoshuajr merged 8 commits into
reactjs:masterfrom
andrescalco:special-props-translation
Feb 9, 2019
Merged

Special props translation#28
fjoshuajr merged 8 commits into
reactjs:masterfrom
andrescalco:special-props-translation

Conversation

@andrescalco

@andrescalco andrescalco commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

#1

glaucia86
glaucia86 suggested changes Feb 9, 2019
View reviewed changes

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrescalco pequenas altera莽玫es a serem feitas. Altere agora que j谩 aprovo esse PR. ;)

Comment thread content/warnings/special-props.md Outdated
Comment thread content/warnings/special-props.md Outdated
@glaucia86 glaucia86 added the needs review A pull request ready to be reviewed label Feb 9, 2019
@glaucia86 @andrescalco
Update content/warnings/special-props.md
333a875 
Co-Authored-By: andrescalco <andre@andrescalco.com>
glaucia86
glaucia86 previously approved these changes Feb 9, 2019
View reviewed changes

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

cc: @cezaraugusto @WendellAdriel it's a short translation. Can we approve this PR?

@glaucia86 glaucia86 added the needs +1 Needs another approval before merging label Feb 9, 2019
@andrescalco

andrescalco commented Feb 9, 2019

Copy link
Copy Markdown
Contributor Author

Prontinho! Amanh茫 acho que consigo pegar mais alguns dos warnings e traduz铆-los XD

eduardomoroni
eduardomoroni previously requested changes Feb 9, 2019
View reviewed changes

@eduardomoroni eduardomoroni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algumas sugest玫es @andrescalco, caso n茫o ache relevante me da o toque que a gente mergeia. :)

Comment thread content/warnings/special-props.md Outdated
Comment thread content/warnings/special-props.md Outdated
@eduardomoroni eduardomoroni added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Feb 9, 2019
@andrescalco

andrescalco commented Feb 9, 2019

Copy link
Copy Markdown
Contributor Author

@eduardomoroni as sugest玫es fazem sentido sim! Vou alterar e fazer o commit.

@glaucia86 seria interessante l谩 na #1 fazer o assign dessa tradu莽茫o para mim,n茫o acha?

@andrescalco

andrescalco commented Feb 9, 2019

Copy link
Copy Markdown
Contributor Author

Meu 煤ltimo commit n茫o tinha as alter莽玫es da @glaucia86. Agora est谩 tudo certo XD

fjoshuajr
fjoshuajr suggested changes Feb 9, 2019
View reviewed changes

@fjoshuajr fjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veja estas sugest玫es por favor.

Comment thread content/warnings/special-props.md Outdated
@fjoshuajr @andrescalco
Update content/warnings/special-props.md
da38a48 
Co-Authored-By: andrescalco <andre@andrescalco.com>
cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes

@cezaraugusto cezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
@fjoshuajr
fjoshuajr dismissed eduardomoroni鈥檚 stale review February 9, 2019 21:46

Feedback addressed 馃憣

@fjoshuajr
fjoshuajr merged commit e8b79aa into reactjs:master Feb 9, 2019
@fjoshuajr fjoshuajr added 馃寪 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
Closed
90 tasks
devin-ai-integration Bot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@andrescalco @fjoshuajr
Special props translation (reactjs#28)
340f250 
* Add pt-BR translation to the special-props page

* Fix typos

* Update content/warnings/special-props.md

Co-Authored-By: andrescalco <andre@andrescalco.com>

* Update special-props.md

* Add small changes

* Add small changes

* Update content/warnings/special-props.md

Co-Authored-By: andrescalco <andre@andrescalco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@cezaraugusto cezaraugusto cezaraugusto approved these changes
@fjoshuajr fjoshuajr fjoshuajr approved these changes
@eduardomoroni eduardomoroni eduardomoroni left review comments
@glaucia86 glaucia86 glaucia86 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

馃寪 translated Translation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andrescalco @eduardomoroni @glaucia86 @cezaraugusto @fjoshuajr