Translate page dont-call-proptypes.md - #19
Merged
Merged
Conversation
Signed-off-by: Matheus Clark dos Santos Monte <matheus.m@samsung.com>
Contributor
Author
|
#1 Warning -> Don't call Proptypes Warning Page |
glaucia86
reviewed
Feb 8, 2019
glaucia86
reviewed
Feb 8, 2019
glaucia86
reviewed
Feb 8, 2019
glaucia86
reviewed
Feb 8, 2019
glaucia86
reviewed
Feb 8, 2019
| ``` | ||
|
|
||
| In this case, `ThirdPartyPropTypes.deprecated` is a wrapper calling `PropTypes.bool`. This pattern by itself is fine, but triggers a false positive because React thinks you are calling PropTypes directly. The next section explains how to fix this problem for a library implementing something like `ThirdPartyPropTypes`. If it's not a library you wrote, you can file an issue against it. | ||
| Nesse caso, `ThirdPartyPropTypes.deprecated` 茅 um wrapper chamando `PropTypes.bool`. Esse padr茫o por si s贸 j谩 茅 o suficiente, mas dispara um falso positivo pelo fato do React pensar que est谩 chamando diretamente a PropTypes. No pr贸ximo t贸pico, iremos explicar como resolver esse problema para a implementa莽茫o de uma biblioteca, algo como `ThirdPartyPropTypes`. Caso n茫o seja uma biblioteca que voc锚 escreveu, voc锚 pode abrir um issue por isso. |
Contributor
There was a problem hiding this comment.
Suggested change
| Nesse caso, `ThirdPartyPropTypes.deprecated` 茅 um wrapper chamando `PropTypes.bool`. Esse padr茫o por si s贸 j谩 茅 o suficiente, mas dispara um falso positivo pelo fato do React pensar que est谩 chamando diretamente a PropTypes. No pr贸ximo t贸pico, iremos explicar como resolver esse problema para a implementa莽茫o de uma biblioteca, algo como `ThirdPartyPropTypes`. Caso n茫o seja uma biblioteca que voc锚 escreveu, voc锚 pode abrir um issue por isso. | |
| Nesse caso, `ThirdPartyPropTypes.deprecated` 茅 um wrapper chamando `PropTypes.bool`. Esse padr茫o por si s贸 j谩 茅 o suficiente. Mas, dispara um falso positivo pelo fato do React pensar que est谩 chamando diretamente a PropTypes. No pr贸ximo t贸pico, iremos explicar como resolver esse problema para a implementa莽茫o de uma biblioteca, algo como `ThirdPartyPropTypes`. Caso n茫o seja uma biblioteca que voc锚 escreveu, voc锚 pode abrir um issue para isso. |
Contributor
There was a problem hiding this comment.
Acho a modifica莽茫o de "[...], mas [...]" para "[...]. Mas, [...]" errada neste caso.
glaucia86
reviewed
Feb 8, 2019
glaucia86
reviewed
Feb 8, 2019
| Se voc锚 茅 o autor de uma biblioteca terceira com PropTypes e permite que seus usu谩rios fa莽am wrap de uma React PropTypes existente, provavelmente eles come莽ar茫o a receber esse warning da sua biblioteca. Isso acontece porque o React n茫o enxerga um 煤ltimo par芒metro "secreto" que passa a [detectar](https://github.com/facebook/react/pull/7132) manualmente as chamadas da PropTypes. | ||
|
|
||
| Here is how to fix it. We will use `deprecated` from [react-bootstrap/react-prop-types](https://github.com/react-bootstrap/react-prop-types/blob/0d1cd3a49a93e513325e3258b28a82ce7d38e690/src/deprecated.js) as an example. The current implementation only passes down the `props`, `propName`, and `componentName` arguments: | ||
| Aqui est谩 como corrigir isso. Usaremos `deprecated` daqui [react-bootstrap/react-prop-types](https://github.com/react-bootstrap/react-prop-types/blob/0d1cd3a49a93e513325e3258b28a82ce7d38e690/src/deprecated.js) como exemplo. A atual implementa莽茫o s贸 passa adiante as `props`, `propName`, and `componentName` arguments: |
Contributor
There was a problem hiding this comment.
Suggested change
| Aqui est谩 como corrigir isso. Usaremos `deprecated` daqui [react-bootstrap/react-prop-types](https://github.com/react-bootstrap/react-prop-types/blob/0d1cd3a49a93e513325e3258b28a82ce7d38e690/src/deprecated.js) como exemplo. A atual implementa莽茫o s贸 passa adiante as `props`, `propName`, and `componentName` arguments: | |
| Aqui est谩 como corrigir isso. Usaremos `deprecated` daqui [react-bootstrap/react-prop-types](https://github.com/react-bootstrap/react-prop-types/blob/0d1cd3a49a93e513325e3258b28a82ce7d38e690/src/deprecated.js) como exemplo. A atual implementa莽茫o s贸 passa adiante as `props`, `propName`, e`componentName` arguments: |
glaucia86
reviewed
Feb 8, 2019
glaucia86
suggested changes
Feb 8, 2019
glaucia86
left a comment
Contributor
There was a problem hiding this comment.
@matheusmonte algumas altera莽玫es a serem corrigidas.
Pedimos que deem uma olhada no review feito e quando for corrigir, pedimos que marque como 'Resolve Conversation'
Ap贸s aprova莽茫o de 2 code reviews, iremos aprovar a sua contribui莽茫o. Muito obrigada! :)
added 2 commits
February 8, 2019 17:35
Signed-off-by: Matheus Clark dos Santos Monte <matheus.m@samsung.com>
Signed-off-by: Matheus Clark dos Santos Monte <matheus.m@samsung.com>
glaucia86
approved these changes
Feb 8, 2019
Contributor
|
cc: @cezaraugusto could you see if this PR it's okay? |
cezaraugusto
approved these changes
Feb 9, 2019
cezaraugusto
left a comment
Contributor
There was a problem hiding this comment.
nice translation, LGTM. thanks @matheusmonte!
Contributor
|
@glaucia86 could you do a follow-up PR with the changes you requested here? I'm merging now |
90 tasks
devin-ai-integration Bot
pushed a commit
to WalissonRodrigo/pt-br.react.dev
that referenced
this pull request
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matheus Clark dos Santos Monte matheus.m@samsung.com