Skip to content

Added react-present-remote to showcase. - #7392

Closed
limscoder wants to merge 2 commits into
react:masterfrom
limscoder:master
Closed

Added react-present-remote to showcase.#7392
limscoder wants to merge 2 commits into
react:masterfrom
limscoder:master

Conversation

@limscoder

Copy link
Copy Markdown

Added app to the showcase: https://github.com/limscoder/react-present/tree/master/remote

Website builds and displays properly.

@ghost

ghost commented May 4, 2016

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 4, 2016
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@limscoder updated the pull request.

name: 'react-present remote',
icon: 'https://lh3.googleusercontent.com/o17riYlDAyKI6Yu6grtqfZadk0KFqdjWgqonC-p9-1RhhUTDh8Nh1ZFMToHo2hjA9Aw=w300-rw',
link: 'https://github.com/limscoder/react-present/tree/master/remote',
linkPlayStore: 'https://play.google.com/store/apps/details?id=com.github.limscoder.ReactPresent',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing comma here as per style in the rest of the file :)

@ghost

ghost commented Jun 7, 2016

Copy link
Copy Markdown

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @brentvatne as a potential reviewer. Could you take a look please or cc someone with more context?

@lacker

lacker commented Jun 21, 2016

Copy link
Copy Markdown
Contributor

Hey, I'm really sorry for the churn, but we are changing up how the showcase works, and just focusing on apps that have some media presence or technical blog posts / other content. So I appreciate the spirit behind this pull request but I think we should close it.

@lacker lacker closed this Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants