Make SPlot.to_gplot use parent's implementation - #18
Merged
Conversation
Conflicts: lib/gnuplot.rb Merge with branch master from rdp/ruby_gnuplot
rdp
added a commit
that referenced
this pull request
Jan 2, 2013
Make SPlot.to_gplot use parent's implementation
Owner
|
Ok try v 2.6.2, and thank you for your help. On Wed, Jan 2, 2013 at 3:23 PM, Leandro Loriato notifications@github.comwrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As referred in issue #16, SPlot.to_gplot implementation should use parent's implementation, while leaving there the method body as to allow for a specific implementation in the future.
(This pull request intends to replace #17, as I've only now correctly merged my update with those from rdp).