fixed CHEF-216

Author: Nuo Yan

chef/lib/chef/mixin/command.rb

@@ -228,6 +228,11 @@ def popen4(cmd, args={}, &b)
                 ENV[key] = value
               end
             end
+
+            if args[:umask]
+              umask = ((args[:umask].respond_to?(:oct) ? args[:umask].oct : args[:umask].to_i) & 007777)
+              File.umask(umask)
+            end
 
             begin
               if cmd.kind_of?(Array)

chef/lib/chef/provider/execute.rb

@@ -44,6 +44,7 @@ def action_run
         command_args[:user] = @new_resource.user if @new_resource.user
         command_args[:group] = @new_resource.group if @new_resource.group
         command_args[:cwd] = @new_resource.cwd if @new_resource.cwd
+        command_args[:umask] = @new_resource.umask if @new_resource.umask
 
         status = run_command(command_args)
         if status
@@ -54,4 +55,4 @@ def action_run
 
     end
   end
-end
+end

chef/lib/chef/resource/execute.rb

@@ -37,16 +37,25 @@ def initialize(name, collection=nil, node=nil)
         @timeout = nil
         @user = nil
         @allowed_actions.push(:run)
+        @umask = nil
       end
-      
+
+      def umask(arg=nil)
+        set_or_return(
+          :umask,
+          arg,
+          :kind_of => [ String, Integer ]
+        )
+      end
+    
       def command(arg=nil)
         set_or_return(
           :command,
           arg,
           :kind_of => [ String ]
         )
       end
-
+      
       def creates(arg=nil)
         set_or_return(
           :creates,
@@ -111,6 +120,8 @@ def user(arg=nil)
         )
       end
 
+
+
     end
   end
-end
+end

features/execute_commands.feature

@@ -9,6 +9,13 @@ Feature: Execute Commands
      When I run the chef-client
      Then the run should exit '0'
       And a file named 'mastodon_rocks' should exist
+      
+  Scenario: Execute a command with umask value 777
+    Given a validated node
+      And it includes the recipe 'execute_commands::umask'
+     When I run the chef-client
+     Then the run should exit '0'
+      And '/mastodon_rocks_umask' should exist and raise error when copying
 
   Scenario: Execute a command with more than 4k of output
     Given a validated node

features/steps/files.rb

@@ -44,6 +44,13 @@
   File.exists?(File.join(tmpdir, filename)).should be(false)
 end
 
+#currently using absolute path (specified in recipe execute_commands/recipes/umask.rb)
+Then /^'(.+)' should exist and raise error when copying$/ do |filename|
+  File.exists?(filename).should be(true)
+  lambda{copy(filename, filename + "_copy", false)}.should raise_error()
+end
+
+
 Then /^the (.)time of '(.+)' should be different$/ do |time_type, filename|
   case time_type
   when "m"