fixed CHEF-195(file.rb, file_spec.rb)

Author: Nuo Yan

chef/lib/chef/provider/file.rb

@@ -159,7 +159,7 @@ def action_touch
 
       def backup(file=nil)
         file ||= @new_resource.path
-        if @new_resource.backup >0 && ::File.exist?(file)
+        if @new_resource.backup > 0 && ::File.exist?(file)
           time = Time.now
           savetime = time.strftime("%Y%m%d%H%M%S")
           backup_filename = "#{@new_resource.path}.chef-#{savetime}"
@@ -176,7 +176,6 @@ def backup(file=nil)
               FileUtils.rm(backup_to_delete)
             end
           end
-
         end
       end
 

chef/spec/unit/provider/file_spec.rb

@@ -220,7 +220,16 @@
     File.stub!(:exist?).and_return(true)
     @provider.backup
   end
-  
+
+  it "should not attempt to backup a file if :backup == 0" do
+    @provider.load_current_resource
+    @provider.new_resource.stub!(:path).and_return("/tmp/s-20080705111233")
+    @provider.new_resource.stub!(:backup).and_return(0)
+    FileUtils.stub!(:cp).and_return(true)
+    File.stub!(:exist?).and_return(true)
+    FileUtils.should_not_receive(:cp)  
+    @provider.backup
+  end
 end
 
 describe Chef::Provider::File, "action_create_if_missing" do
@@ -236,4 +245,4 @@
     @provider.should_receive(:action_create).and_return(true)
     @provider.action_create_if_missing
   end
-end
+end