Skip to content
This repository was archived by the owner on May 13, 2026. It is now read-only.

add pytorch to list#264

Merged
takluyver merged 2 commits into
python3statement:masterfrom
soumith:master
Sep 26, 2019
Merged

add pytorch to list#264
takluyver merged 2 commits into
python3statement:masterfrom
soumith:master

Conversation

@soumith

@soumith soumith commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

If you're adding a project to the Python 3 statement, please ensure you have:

  • Discussed dropping Python 2 support with all maintainers
  • Discussed signing the statement with all maintainers
  • Added a suitable logo if the project has one
    • Approximately square logos generally fit better than banners
    • Compressed the logo to save bandwidth (run scripts/squash-images.sh on it)
  • Checked the Netlify preview made from the pull request

@takluyver

Copy link
Copy Markdown
Member

Thanks, this all looks good. I'll give it a day or two for any pytorch maintainers to chime in. By that point I'll inevitably have forgotten, so ping me in a couple of days if there are no objections, and I'll merge it.

@soumith

soumith commented Sep 24, 2019

Copy link
Copy Markdown
Contributor Author

fyi, we've discussed it at pytorch/pytorch#23795 and we're (pytorch maintainers) are all good on this.

But sure, I can ping you in a couple of days.

@takluyver

Copy link
Copy Markdown
Member

It looks like there hasn't been much discussion about signing the statement specifically: it's only suggested by @hugovk's post about a month ago, and then there are no responses until you mentioned this PR today.

It doesn't seem likely that anyone will object, but we've had at least one project that resolved to drop Python 2 support but not to sign this statement, so I take care not to merge any new signatures too quickly. :-)

@takluyver

Copy link
Copy Markdown
Member

(Obviously if I've overlooked some discussion about the statement, please correct me!)

@soumith

soumith commented Sep 26, 2019

Copy link
Copy Markdown
Contributor Author

pinging after two days :)

(Obviously if I've overlooked some discussion about the statement, please correct me!)

Yes, sorry the maintainers also discussed it on our private slack channel but that's not publicly visible info.

@takluyver

Copy link
Copy Markdown
Member

Thanks, and welcome aboard! :-)

@takluyver
takluyver merged commit b224f8b into python3statement:master Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants