Skip to content

A better error message from importlib.resources.files() when module spec is None #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 6 commits into from
Apr 12, 2026
Merged

A better error message from importlib.resources.files() when module spec is None #331

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47b3f09
A better error message from importlib.resources.files() when module s…
whitphx Oct 22, 2025
74f308a
Revert unrelated change to `wrap_spec`.
jaraco Apr 12, 2026
a542188
Extract method to encapsulate the validation.
jaraco Apr 12, 2026
ee94f7c
Merge branch 'main' into error-message-none-spec-module
jaraco Apr 12, 2026
6e2183f
Revise the test for clarity and traceability.
jaraco Apr 12, 2026
d80822a
Add news fragment.
jaraco Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revise the test for clarity and traceability.
  • Loading branch information
@jaraco
jaraco committed Apr 12, 2026
commit 6e2183f425ce89a743db51288dc6097ac8a8e115
12 changes: 8 additions & 4 deletions importlib_resources/tests/test_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,13 +220,17 @@ class ResourceFromNamespaceZipTests(
MODULE = 'namespacedata01'


class ResourceFromMainModuleWithNoneSpecTests(unittest.TestCase):
# `__main__.__spec__` can be `None` depending on how it is populated.
# https://docs.python.org/3/reference/import.html#main-spec
class MainModuleTests(unittest.TestCase):
def test_main_module_with_none_spec(self):
"""
__main__ module with no spec should raise TypeError (for clarity).

See python/cpython#138531 for details.
"""
# construct a __main__ module with no __spec__.
mainmodule = types.ModuleType("__main__")

self.assertIsNone(mainmodule.__spec__)
assert mainmodule.__spec__ is None

with self.assertRaises(
TypeError,
Expand Down