Skip to content

bpo-41972: Tweak fastsearch.h string search algorithms #27091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 21 commits into from
Jul 19, 2021
Merged

bpo-41972: Tweak fastsearch.h string search algorithms #27091

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
90a6a0c
Don't force inlining
sweeneyde Jul 6, 2021
19fa661
Use a Boyer-Moore skip table
sweeneyde Jul 7, 2021
d2219d5
Switch to two-way in more cases
sweeneyde Jul 8, 2021
3b8760f
Tighter comments
sweeneyde Jul 9, 2021
5d86b8d
Fix the direction of the cutoff inequality :)
sweeneyde Jul 10, 2021
2e9a9b1
Separate a gap loop
sweeneyde Jul 10, 2021
c84314c
update cutoffs
sweeneyde Jul 10, 2021
7517c60
tweak cutoffs, fix i - cut + 1 jump
sweeneyde Jul 10, 2021
e5ef33b
Refactor into smaller functions
sweeneyde Jul 11, 2021
a01fb70
Focus the table on the last character of the pattern, giving a tighte…
sweeneyde Jul 11, 2021
6be0c32
tweak cutoffs
sweeneyde Jul 11, 2021
f9fe807
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 12, 2021
25f9b56
Fix sanitizer warnings
sweeneyde Jul 12, 2021
d3f8438
Merge branch 'fastersearch' of https://github.com/sweeneyde/cpython i…
sweeneyde Jul 12, 2021
4379ea6
Refactor for sanitizer
sweeneyde Jul 12, 2021
e336b79
Don't goto declarations
sweeneyde Jul 12, 2021
b8df3e1
Emphasize to the compiler that the loop is a loop
sweeneyde Jul 13, 2021
869f7d0
Use Py_LOCAL_INLINE
sweeneyde Jul 15, 2021
747a39a
Use Py_LOCAL_INLINE again
sweeneyde Jul 15, 2021
72143ef
Tweak thresholds based on most recent comparison.
sweeneyde Jul 16, 2021
4d7d102
Fix greater/less than sign.
sweeneyde Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak cutoffs
  • Loading branch information
@sweeneyde
sweeneyde committed Jul 11, 2021
commit 6be0c32379205935cb907182c33b6f651b2eaf76
4 changes: 2 additions & 2 deletions Objects/stringlib/fastsearch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,10 +748,10 @@ FASTSEARCH(const STRINGLIB_CHAR* s, Py_ssize_t n,
}

if (mode != FAST_RSEARCH) {
if (n < 2000 || (m < 100 && n < 30000) || m < 6) {
if (n < 3000 || (m < 100 && n < 30000) || m < 6) {

@ambv ambv Jul 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you come about those numbers?

@sweeneyde sweeneyde Jul 15, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll consolidate the benchmarks I used and post them here. But this is a chart comparing the default implementation to the existing two-way implementation. The equivalent chart for this implementation is similar, and I'm trying to essentially to cut out the green bits of that image.

For now though, the differences this PR makes have some benchmarks here

return STRINGLIB(default_find)(s, n, p, m, maxcount, mode);
}
else if (5 * m < n) {
else if (6 * m < n) {
/* For larger problems where the needle isn't a huge
percentage of the size of the haystack, the relatively
expensive O(m) startup cost of the two-way algorithm
Expand Down