Skip to content

gh-151815: Fix crash in t-string iterator on partial construction under OOM #154714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Vamsi-klu wants to merge 1 commit into from
+4 −1
Closed

gh-151815: Fix crash in t-string iterator on partial construction under OOM #154714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-07-26-12-00-01.gh-issue-151815.d4e5f6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a crash in t-string iteration when creating the iterator fails partway through due to memory pressure.
4 changes: 3 additions & 1 deletion Objects/templateobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ template_iter(PyObject *op)
if (iter == NULL) {
return NULL;
}
iter->stringsiter = NULL;
iter->interpolationsiter = NULL;
iter->from_strings = 1;

PyObject *stringsiter = PyObject_GetIter(self->strings);
if (stringsiter == NULL) {
Expand All @@ -242,7 +245,6 @@ template_iter(PyObject *op)

iter->stringsiter = stringsiter;
iter->interpolationsiter = interpolationsiter;
iter->from_strings = 1;
PyObject_GC_Track(iter);
return (PyObject *)iter;
}
Expand Down
Loading