Update vehicle_purchase_test.cpp - #3
Open
pdmoore wants to merge 1 commit into
Open
Conversation
Current tests for choose_vehicle allow a simplistic implementation of return option1 + " is clearly the better choice."; to pass all tests without comparing option1 and option2. This is due to the current tests all passing in option1 and option2 sorted in lexicographic order already. This change swaps option1 and option2 for a couple of the tests which forces the implementation to compare the parameters. This change will not impact existing solutions that are correctly implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current tests for choose_vehicle allow a simplistic implementation of return option1 + " is clearly the better choice."; to pass all tests without comparing option1 and option2.
This is due to the current tests all passing in option1 and option2 sorted in lexicographic order already.
This change swaps option1 and option2 for a couple of the tests which forces the implementation to compare the parameters.
This change will not impact existing solutions that are correctly implemented.