Skip to content

Fix Absent::foldLeft bug #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnape merged 1 commit into from
Dec 2, 2022
Merged

Fix Absent::foldLeft bug #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/jnape/palatable/lambda/semigroup/builtin/Absent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public Maybe<A> checkedApply(Maybe<A> maybeX, Maybe<A> maybeY) {
@Override
public Maybe<A> foldLeft(Maybe<A> acc, Iterable<Maybe<A>> maybes) {
return trampoline(
into((res, it) -> res.equals(nothing())
into((res, it) -> res.equals(nothing()) || !it.hasNext()
? terminate(res)
: recurse(tuple(liftA2(aSemigroup, res, it.next()), it))),
tuple(acc, maybes.iterator()));
Expand Down
7 changes: 7 additions & 0 deletions src/test/java/com/jnape/palatable/lambda/semigroup/builtin/AbsentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ public void foldLeftShortCircuit() {
assertEquals(nothing(), result);
}

@Test
public void foldLeftWorksForJusts() {
Maybe<Unit> result = Absent.<Unit>absent(Constantly::constantly)
.foldLeft(just(UNIT), Arrays.asList(just(UNIT), just(UNIT)));
assertEquals(just(UNIT), result);
}

@Test(timeout = 200)
public void checkedApplyFoldRightShortCircuit() {
Maybe<Unit> result = Absent.<Unit>absent().checkedApply(Constantly::constantly)
Expand Down