Add pipeline for tests - #203
Closed
thejaminator wants to merge 7 commits into
Closed
Conversation
thejaminator
commented
Feb 4, 2023
| assert result.purpose == "search" | ||
| assert result.purpose == "fine-tune" | ||
| assert "id" in result | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@Andrew-Chen-Wang this test was failing, i just copied the test case from the synchronous version to fix it.
Contributor
Author
Contributor
|
Thanks for this! We've since rewritten the library entirely, so this change is no longer relevant. I'm sorry we didn't get to it sooner. We currently run CI for this repo in a private mirror, but hope to add public CI with tests soon. |
safa0
pushed a commit
to safa0/openai-agents-python
that referenced
this pull request
Apr 27, 2025
## Context By default, the outputs of tools are sent to the LLM again. The LLM gets to read the outputs, and produce a new response. There are cases where this is not desired: 1. Every tool results in another round trip, and sometimes the output of the tool is enough. 2. If you force tool use (via model settings `tool_choice=required`), then the agent will just infinite loop. This enables you to have different behavior, e.g. use the first tool output as the final output, or write a custom function to process tool results and potentially produce an output. ## Test plan Added new tests and ran existing tests Also added examples. Closes openai#117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a CI pipeline to run tests.
Should catch errors like this as well. #199
Example on my fork here thejaminator#1
The maintainers of this repo will need to set an environment API key
OPENAI_API_KEY=<API-KEY>as a github secret, so the tests that require an API key will be run as part of the pipeline.Alternatively, tests that require authentication with the API key can be separated from those that don't. And we can disable those that require authentication. Or mock the API response.