doc,lib,src,test: unflag sqlite module - #55890
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55890 +/- ##
==========================================
- Coverage 88.41% 88.41% -0.01%
==========================================
Files 654 654
Lines 188036 188036
Branches 36187 36182 -5
==========================================
- Hits 166260 166257 -3
- Misses 14989 14990 +1
- Partials 6787 6789 +2
|
jakecastelli
approved these changes
Nov 17, 2024
marco-ippolito
approved these changes
Nov 17, 2024
Collaborator
MoLow
approved these changes
Nov 17, 2024
targos
approved these changes
Nov 18, 2024
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: nodejs#55854
cjihrig
force-pushed
the
unflag-sqlite
branch
from
November 18, 2024 13:43
de77663 to
a54b0ac
Compare
Contributor
Author
|
Rebased to fix a minor conflict in the docs from #54181. |
Collaborator
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Collaborator
Collaborator
Collaborator
|
Landed in 1d01ad6 |
This was referenced Dec 11, 2024
2 tasks
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #55854...
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental.
Fixes: #55854