lib: add SafeArray to primordials and use it for FreeList - #36600
lib: add SafeArray to primordials and use it for FreeList#36600ExE-Boss wants to merge 1 commit into
SafeArray to primordials and use it for FreeList#36600Conversation
|
Run Benchmark on my computer, seems the performance issues still exists. |
|
Looks like the benchmark CI crashed: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/783/console |
aduh95
left a comment
There was a problem hiding this comment.
Benchmark confirmed very poor performance results…
confidence improvement accuracy (*) (**) (***)
misc/freelist.js n=100000 *** -91.36 % ±3.89% ±5.24% ±6.96%
|
If I had to guess, I’d say V8 is doing some inlining shenanigans when it detects a By inlining the methods in #37649, I hope to make |
|
This pull request has been marked as stale due to 90 days of inactivity. |
Refs: #36304 (comment)
Refs: #36565
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes