Skip to content

v8: expose new V8 5.5 serialization API #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

v8: expose new V8 5.5 serialization API #11048

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ae0d86
buffer: expose FastBuffer on internal/buffer
addaleax Feb 28, 2017
9db1853
v8: expose new V8 serialization API
addaleax Jan 27, 2017
a3decc4
[squash] fix bug from targos’ review
addaleax Mar 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] fix bug from targos’ review
  • Loading branch information
@addaleax
addaleax committed Mar 27, 2017
commit a3decc4cb9515ea36aed3df7392a0aaf7467a27f
7 changes: 6 additions & 1 deletion lib/v8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,12 @@ class DefaultSerializer extends Serializer {
if (abView.constructor === Buffer) {
i = bufferConstructorIndex;
} else {
i = arrayBufferViewTypeToIndex.get(objectToString(abView));
const tag = objectToString(abView);
i = arrayBufferViewTypeToIndex.get(tag);

if (i === undefined) {
throw this._getDataCloneError(`Unknown host object type: ${tag}`);
}
}

@targos targos Mar 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this throw an error when i is undefined (unknown host object)?

@addaleax addaleax Mar 27, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@targos Yes thanks for catching! Updated + test added

this.writeUint32(i);
this.writeUint32(abView.byteLength);
Expand Down
5 changes: 5 additions & 0 deletions test/parallel/test-v8-serdes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ const objects = [
}, /foobar/);
}

{
assert.throws(() => v8.serialize(process.stdin._handle),
/^Error: Unknown host object type: \[object .*\]$/);
}

{
const buf = Buffer.from('ff0d6f2203666f6f5e007b01', 'hex');

Expand Down