Skip to content

Remove code and tests for unsupported Python 2.6, 3.3 and 3.4#249

Merged
methane merged 7 commits into
msgpack:masterfrom
hugovk:rm-unsupported
Nov 2, 2017
Merged

Remove code and tests for unsupported Python 2.6, 3.3 and 3.4#249
methane merged 7 commits into
msgpack:masterfrom
hugovk:rm-unsupported

Conversation

@hugovk

@hugovk hugovk commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

c11bb64 says:

Python 3.3 and 3.4 will not be supported officially in next minor version

And 2.6 was dropped in #168.

This removes some 2.6, 3.3 and 3.4 stuff.

Also remove this restriction form .travis.yml to allow me to test this feature branch before creating the PR:

-branches:		
-  only:		
-    - master		
-

I think this is a good thing to keep, but let me know if you'd like it putting back.

Also ignore .cache directory, created from build/test.

@hugovk

hugovk commented Oct 12, 2017

Copy link
Copy Markdown
Contributor Author

The Docker CI failure also happens on master.

@methane

methane commented Oct 12, 2017

Copy link
Copy Markdown
Member

I just want don't announce "Python 3.3 and 3.4 are supported."
Don't remove test until it make trouble.

@methane

methane commented Oct 12, 2017

Copy link
Copy Markdown
Member

Removing code for 2.6 is nice.

@hugovk

hugovk commented Oct 12, 2017

Copy link
Copy Markdown
Contributor Author

Please see #250.

@hugovk

hugovk commented Nov 1, 2017

Copy link
Copy Markdown
Contributor Author

Merge conflict resolved.

@hugovk

hugovk commented Nov 1, 2017

Copy link
Copy Markdown
Contributor Author

By the way, here's the pip installs for msgpack-python from PyPI for the last month:

$ pypinfo --percent --pip msgpack-python pyversion
python_version percent download_count
-------------- ------- --------------
2.7              83.9%        669,038
3.6               6.6%         52,967
3.5               6.2%         49,744
3.4               2.9%         22,903
2.6               0.2%          1,980
3.3               0.1%            484
3.7               0.0%            278
None              0.0%              6
3.2               0.0%              3
3.1               0.0%              1

This shows Python 2.6 and 3.3 have very little usage.

@methane

methane commented Nov 2, 2017

Copy link
Copy Markdown
Member

OK, simplifying appveyor.yml looks nice.

@methane
methane merged commit 3a09885 into msgpack:master Nov 2, 2017
@methane

methane commented Nov 2, 2017

Copy link
Copy Markdown
Member

thanks

@hugovk
hugovk deleted the rm-unsupported branch November 2, 2017 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants