Skip to content

Added my tutorial notebook model_training.ipynb - #294

Merged
Gustavo Hidalgo (ghidalgo3) merged 7 commits into
microsoft:mainfrom
jeanahoffmann:main
Aug 16, 2024
Merged

Added my tutorial notebook model_training.ipynb#294
Gustavo Hidalgo (ghidalgo3) merged 7 commits into
microsoft:mainfrom
jeanahoffmann:main

Conversation

@jeanahoffmann

Copy link
Copy Markdown
Contributor

I added my tutorial notebook that encompasses my intern project work under tutorials/model_training.ipynb. I also added the .json file for the Polygon land areas under tutorials/assets/map.json.

…ded the file map.json under a new folder assets under tutorials/ as well
@jeanahoffmann

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@ghidalgo3

Gustavo Hidalgo (ghidalgo3) commented Aug 16, 2024

Copy link
Copy Markdown
Collaborator
  1. In the cell directly following I. Object Collection, the whole text is in a ### heading block. Should that be a normal paragraph? I think that's repeated a couple of times wherever you combined notebooks.
  2. In python, the documentation string """text""" goes just after the function signature definition, not before it. It's not like C#/Java, closer to documentation strings.
  3. Right before the start of the second section, can you mention at that point that randomly sampling from the entire globe is good but for specialized models users may want to sample from smaller areas by modifying the json file.
  4. Don't use the language "my project" for this notebook, write "this tutorial" instead.
  5. Where did you get the quote "noisy but semantically diverse image-text datasets [are capable]"?
  6. "The keys included are my choice and should be taken with a grain of salt ;)" more formal tone please
  7. Can you change the link to create an OpenAI Azure resource to point here: https://azure.microsoft.com/en-us/products/ai-services/openai-service
  8. I don't think its necessary to talk about Role Assignments

@jeanahoffmann

Copy link
Copy Markdown
Contributor Author

Ok I added in all of your suggestions! Thanks so much for taking the time to review the notebook! Let me know if there's anything else I should fix.

@ghidalgo3
Gustavo Hidalgo (ghidalgo3) merged commit 5d207dd into microsoft:main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants