Note Safari IME key event ordering bug affecting isComposing#30009
Open
caugner wants to merge 1 commit into
Open
Note Safari IME key event ordering bug affecting isComposing#30009caugner wants to merge 1 commit into
caugner wants to merge 1 commit into
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
d2b27e2 to
4a44a1d
Compare
Safari dispatches the keydown and input events for the key that completes an IME composition session after the compositionend event (WebKit bug 165004), so isComposing is incorrectly false instead of true on those events. Document this on KeyboardEvent.isComposing and InputEvent.isComposing without changing support values, since the bug does not warrant marking these features partial or unsupported.
4a44a1d to
cc4b5ad
Compare
caugner
commented
Jul 8, 2026
Comment on lines
+272
to
+273
| "version_added": "16.4", | ||
| "notes": "In Safari, the `keydown` and `input` events for the key that completes an IME composition session are dispatched after the `compositionend` event, so their `isComposing` value is incorrectly `false` instead of `true`. Events fired earlier in the session are unaffected. See [bug 165004](https://webkit.org/b/165004)." |
Contributor
Author
There was a problem hiding this comment.
Does this justify partial implementation? (Baseline regression)
Suggested change
| "version_added": "16.4", | |
| "notes": "In Safari, the `keydown` and `input` events for the key that completes an IME composition session are dispatched after the `compositionend` event, so their `isComposing` value is incorrectly `false` instead of `true`. Events fired earlier in the session are unaffected. See [bug 165004](https://webkit.org/b/165004)." | |
| "version_added": "16.4", | |
| "partial_implementation": true, | |
| "notes": "In Safari, the `keydown` and `input` events for the key that completes an IME composition session are dispatched after the `compositionend` event, so their `isComposing` value is incorrectly `false` instead of `true`. Events fired earlier in the session are unaffected. See [bug 165004](https://webkit.org/b/165004)." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Safari notes documenting a known IME composition bug: the
keydownandinputevents for the key that completes an IME composition session are dispatched after thecompositionendevent, so theirisComposingvalue is incorrectlyfalseinstead oftrue. Notes are added to:api.KeyboardEvent.isComposingapi.InputEvent.isComposingSupport values are left unchanged, since the bug does not warrant marking these features as partial or unsupported. The notes are scoped to the
isComposingproperties only, since that is the observable symptom; thekeydownandinputevents themselves are correctly supported.Test results and supporting details
The bug is still reproducible in Safari 26.3 on macOS. A fix (bug 311717) is implemented behind the
InputMethodUsesCorrectKeyEventOrderpreference, which is still marked as unstable.Related issues
Fixes #29998