Skip to content

Some fixes - #65

Merged
jacksondunstan merged 4 commits into
jacksondunstan:masterfrom
Kaladrius2trip:some_fixes
Dec 11, 2020
Merged

Some fixes#65
jacksondunstan merged 4 commits into
jacksondunstan:masterfrom
Kaladrius2trip:some_fixes

Conversation

@Kaladrius2trip

@Kaladrius2trip Kaladrius2trip commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

For searching tags by IndexOf in existing binding files now uses Environment.NewLine.
Because in Windows default newline symbols it's "\r\n" instead "\n". Maybe should use RegEx for this.

And all library build with prefix "lib" so...
I have no idea how to fix it. I use CMake command to replace this by empty string.

@jacksondunstan

Copy link
Copy Markdown
Owner

@Kaladrius2trip Thanks for submitting this PR! I like the newline change and the updates to some of the Unity packages. May I ask why the "lib" prefix should be stripped off of build file names?

@jacksondunstan jacksondunstan self-assigned this Dec 11, 2020
@Kaladrius2trip

Copy link
Copy Markdown
Contributor Author

@jacksondunstan I use MinGW compiler. And library have this prefix on windows platform, but in const you are set lib name without prefix. I added condition for this in CMakeList.

And i changed all "\n" to Environment.NewLine
When use StringBuilder.AppendLine it commonly use NewLine from Environment. With that might have some issue. But i cheked example and generated code looks like same.

@jacksondunstan
jacksondunstan merged commit 5e9e182 into jacksondunstan:master Dec 11, 2020
@jacksondunstan

Copy link
Copy Markdown
Owner

@Kaladrius2trip Thanks for explaining the "lib" prefix and for changing it to only be stripped for MinGW. Thanks also for the the change to output environment-specific newlines. I went ahead and merged your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants