Fix enum34 requirement in setup.py for python 3 - #289
Closed
dzheng256 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thank you, we'll incorporate this change 👍 . |
Collaborator
|
Merged in 878b8d8 |
CherylMoonba
added a commit
to CherylMoonba/devices
that referenced
this pull request
Jul 20, 2025
7d100c145a5a0afc44394e36c4c5c02afba288dc by Daniel Zheng <dzheng256@gmail.com> COPYBARA_INTEGRATE_REVIEW=google/python-fire#289 from dzheng256:patch-1 7d100c145a5a0afc44394e36c4c5c02afba288dc PiperOrigin-RevId: 335459087 Change-Id: Ifafd1ed3793604ed78b487189a0be908d699bd51
hwlegends
pushed a commit
to hwlegends/python-fire
that referenced
this pull request
Aug 20, 2025
7d100c145a5a0afc44394e36c4c5c02afba288dc by Daniel Zheng <dzheng256@gmail.com> COPYBARA_INTEGRATE_REVIEW=google/python-fire#289 from dzheng256:patch-1 7d100c145a5a0afc44394e36c4c5c02afba288dc PiperOrigin-RevId: 335459087 Change-Id: Ifafd1ed3793604ed78b487189a0be908d699bd51
Hernandez19891
added a commit
to Hernandez19891/Illumina
that referenced
this pull request
Sep 15, 2025
7d100c145a5a0afc44394e36c4c5c02afba288dc by Daniel Zheng <dzheng256@gmail.com> COPYBARA_INTEGRATE_REVIEW=google/python-fire#289 from dzheng256:patch-1 7d100c145a5a0afc44394e36c4c5c02afba288dc PiperOrigin-RevId: 335459087 Change-Id: Ifafd1ed3793604ed78b487189a0be908d699bd51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preferred way to specify a requirement that depends on python version is to do something like
'<packagename>; python_version < "3.4"', not to do the sys.version check as is currently being done.I am running into an issue where a wheel is built with py2 and the cached wheel metadata is used again when installing the package for python 3.7, thus incorrectly including
enum34.This same issue is addressed in the stack overflow responses here