[pull] main from openai:main - #141
Merged
Merged
Conversation
…3706) - [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested Keep the fine-tuning positional-argument regression coverage in handwritten tests, then restore the two generated test files to the recorded public generated snapshot. The generated examples use `fine_tuning_job_id=` and their original fake `after` values; the original positional calls remain tested. Only three test files change. Runtime code, dependencies, the API reference, compiler inputs, and generation metadata are unchanged. ## Additional context & links All 20 original methods and their client parameterizations are retained verbatim in [`tests/lib/test_fine_tuning_positional_arguments.py`](https://github.com/openai/openai-python/blob/4dd138db112ee8d02c6803e0f0b812c5c9be3dee/tests/lib/test_fine_tuning_positional_arguments.py): - [`TestCheckpoints`](https://github.com/openai/openai-python/blob/4dd138db112ee8d02c6803e0f0b812c5c9be3dee/tests/lib/test_fine_tuning_positional_arguments.py#L14) and [`TestAsyncCheckpoints`](https://github.com/openai/openai-python/blob/4dd138db112ee8d02c6803e0f0b812c5c9be3dee/tests/lib/test_fine_tuning_positional_arguments.py#L65) preserve `test_method_list`, `test_method_list_with_all_params`, `test_raw_response_list`, `test_streaming_response_list`, and `test_path_params_list`. - [`TestJobs`](https://github.com/openai/openai-python/blob/4dd138db112ee8d02c6803e0f0b812c5c9be3dee/tests/lib/test_fine_tuning_positional_arguments.py#L118) and [`TestAsyncJobs`](https://github.com/openai/openai-python/blob/4dd138db112ee8d02c6803e0f0b812c5c9be3dee/tests/lib/test_fine_tuning_positional_arguments.py#L169) preserve `test_method_list_events`, `test_method_list_events_with_all_params`, `test_raw_response_list_events`, `test_streaming_response_list_events`, and `test_path_params_list_events`. These retain the basic/all-parameter calls, parsed response types, raw/streaming response headers and close behavior, and empty-ID errors. The original loose, strict, and async aiohttp modes remain: **50 positional-call cases**, alongside the restored generated keyword-call examples. Validation: - Exact-source/AST proof for every retained method and parameterization; both generated files match the public snapshot byte-for-byte. - Pytest collection preserves all 50 original class/function/client-mode IDs after normalizing only the destination path, under both Pydantic versions. - `python -m pytest -n 0 tests/lib/test_fine_tuning_positional_arguments.py tests/api_resources/fine_tuning/jobs/test_checkpoints.py tests/api_resources/fine_tuning/test_jobs.py`: **220 passed under Pydantic v2 and 220 under v1**, against the checked-in API mock. - `./scripts/format` and `./scripts/lint` pass, including Ruff, Pyright, mypy, and import checks. Unrelated reporter-only formatting changes are excluded. - Verified public custom-code report: **40 → 38 mixed files**, exactly these two generated test customizations removed, and all other customizations unchanged.
…3707) - [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested Move the three handwritten vector-store helper-signature tests into handwritten test modules, then restore the two API-resource test files to the recorded public generated snapshot. Keep each original function, decorator, comparison, and excluded-parameter set unchanged. Only four test files change. No polling, upload, runtime, dependency, API reference, compiler, or generation-metadata changes. ## Additional context & links The exact retained coverage is: - [`tests/lib/test_vector_store_file_batches.py::test_create_and_poll_method_in_sync`](https://github.com/openai/openai-python/blob/8eaeaad036a156bbd4155c6a426acffa06d13cfd/tests/lib/test_vector_store_file_batches.py#L10) keeps batch `create_and_poll` aligned with `create`. - [`tests/lib/test_vector_store_files.py::test_create_and_poll_method_in_sync`](https://github.com/openai/openai-python/blob/8eaeaad036a156bbd4155c6a426acffa06d13cfd/tests/lib/test_vector_store_files.py#L10) keeps file `create_and_poll` aligned with `create`. - [`tests/lib/test_vector_store_files.py::test_upload_and_poll_method_in_sync`](https://github.com/openai/openai-python/blob/8eaeaad036a156bbd4155c6a426acffa06d13cfd/tests/lib/test_vector_store_files.py#L20) keeps `upload_and_poll` aligned with `create`, retaining exactly the existing exclusions: `file_id`, `extra_headers`, `extra_query`, `extra_body`, and `timeout`. Each still runs for both sync and async clients: all **six original cases** are preserved. The generated API tests remain intact. Validation: - Exact-source/AST proof, including decorators and exclusions; both generated files match the public snapshot byte-for-byte. - Both Pydantic collection checks preserve all six original test IDs after mapping only the file paths. - The two handwritten modules plus both affected API-resource suites pass **226 tests under Pydantic v2 and 226 under v1**, against the checked-in API mock. - `./scripts/format` and `./scripts/lint` pass, including Ruff, Pyright, mypy, and import checks. Unrelated reporter-only formatting changes are excluded. - Verified public custom-code report: **40 → 38 mixed files**, exactly these two customizations removed and every other customization unchanged.
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested Restore the existing ChatKit section in `api.md` from the [recorded public generated snapshot](https://github.com/openai/openai-python/blob/0d3e70da47bb645fbfd0dd16fdd37ea10ee981f5/api.md#L633). The handwritten legacy Realtime section had displaced it. This change retains that section and every other existing line, including documentation for handwritten public helpers. Only `api.md` changes: 50 lines are restored verbatim. All documented ChatKit types and methods already exist in the public SDK. No runtime code, tests, dependencies, API reference, compiler, or generation metadata changes. ## Additional context & links Validation: - Exact-byte comparison with the public generated ChatKit section. - All eight restored source links and both import examples resolve to existing public files/exports; all six documented methods exist in both sync and async resources. - The repository's `scripts/utils/ruffen-docs.py api.md` formatter and `git diff --check` pass. - The verified public custom-code report keeps 40 mixed files, with only `api.md` changed and 39 customizations untouched. Its patch shrinks from **+87/-32 to +105/-0**: the API index no longer deletes generated content. No tests are removed or relocated in this documentation-only cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )