Add wildcard so that all .env files are ignored - Python.gitignore - #4393
Closed
HeyThereSmileMore wants to merge 1 commit into
Closed
Add wildcard so that all .env files are ignored - Python.gitignore#4393HeyThereSmileMore wants to merge 1 commit into
HeyThereSmileMore wants to merge 1 commit into
Conversation
offensive-vk
approved these changes
Feb 19, 2024
|
This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open 😄 |
|
This PR has been closed because it was inactive for 180 days. If you want to continue working on it, please open a new PR. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
So that all files starting with
.envare ignored.Example why this is useful:
With python 3.11 there is now native TOML support, so it is a valid use case to have
.env.tomlfiles.Additionally, it would be useful if more than one ".env" file is present, like ".env_topic1" for example.
Current status
The problem with the current "gitignore" is, that these files are not ignored.
Solution
With the wildcard
.env*they are ignored.Links to documentation supporting these rule changes:
python 3.11 tomlib native support
The Dart gitignore also has the wildcard to ignore all .env* files and from my perspective it would be useful for python too
BTW: If something is missing or not correct, please let me know, this is my first pull request to this repo