Skip to content

JS: Clean up some TODO comments #18451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 14 commits into from
Jan 9, 2025
Merged

JS: Clean up some TODO comments #18451

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3cc1525
JS: Remove obsolete TODOs
asgerf Jan 9, 2025
8ac08db
JS: Remove TODOs about WithArrayElement not being a taint step
asgerf Jan 9, 2025
7766f97
JS: Remove obsolete TODO
asgerf Jan 9, 2025
b29ee2a
JS: Remove references to localFieldStep
asgerf Jan 9, 2025
fb54a3b
JS: Remove obsolete TODO comment
asgerf Jan 9, 2025
dd37c47
JS: Remove mention of results from comments
asgerf Jan 9, 2025
a8f93ca
JS: Remove obsolete comment
asgerf Jan 9, 2025
8b060c4
JS: Remove TODO about evaluating legacy steps
asgerf Jan 9, 2025
388dd87
JS: Remove TODO tracked by an issue.
asgerf Jan 9, 2025
3def8ec
JS: Remove unimportant TODO
asgerf Jan 9, 2025
d9da944
JS: Rephrase TODO
asgerf Jan 9, 2025
b2d62a0
JS: Move a test failure explanation into the test suite
asgerf Jan 9, 2025
3f2882e
JS: Remove an obsolete comment
asgerf Jan 9, 2025
9c4d378
JS: Remove TODO comment
asgerf Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
JS: Remove obsolete TODO comment
  • Loading branch information
@asgerf
asgerf committed Jan 9, 2025
commit fb54a3bde89fc4a30f1b7c4f371105e30cebfbcc
5 changes: 1 addition & 4 deletions javascript/ql/lib/semmle/javascript/security/dataflow/PrototypePollutingAssignmentQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@ module PrototypePollutingAssignmentConfig implements DataFlow::StateConfigSig {
state = FlowState::objectPrototype()
}

predicate isBarrierIn(DataFlow::Node node, FlowState state) {
// FIXME: This should only be an in-barrier for the corresponding flow state, but flow-state specific in-barriers are not supported right now.
isSource(node, state)
}
predicate isBarrierIn(DataFlow::Node node, FlowState state) { isSource(node, state) }

predicate isAdditionalFlowStep(
DataFlow::Node node1, FlowState state1, DataFlow::Node node2, FlowState state2
Expand Down