Skip to content

add topics to grains - #954

Merged
ilya-khadykin merged 4 commits into
exercism:masterfrom
Zaccc123:topics-grains
Oct 24, 2017
Merged

add topics to grains#954
ilya-khadykin merged 4 commits into
exercism:masterfrom
Zaccc123:topics-grains

Conversation

@Zaccc123

Copy link
Copy Markdown
Contributor

fixes #830

@ilya-khadykin ilya-khadykin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

Please read my comment

Comment thread config.json Outdated
"topics": [

"bitwise-operations",
"control-flow-(if-else-statements)",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've switched to snake_case naming convention for topics to increase consistency among tracks, so could you please choose them from the following list - https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt

Please follow the convention

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I had switched it to snake_case and removed topic that is not presented in the TOPICS.txt.

@ilya-khadykin
ilya-khadykin merged commit ce8c579 into exercism:master Oct 24, 2017
@ilya-khadykin

Copy link
Copy Markdown
Contributor

Thanks, @Zaccc123

It's a best practice to squash your commits https://github.com/exercism/docs/blob/master/contributing/git-basics.md#squashing. It isn't a big deal since I can do it myself, but it would be awesome to just click on 'Merge pull request' button 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grains: add topics

2 participants