resistor-color: Improve instructions - #873
Merged
SleeplessByte merged 1 commit intoOct 17, 2020
Merged
Conversation
SleeplessByte
requested changes
Oct 16, 2020
SleeplessByte
left a comment
Member
There was a problem hiding this comment.
Hi there! This is a good way to solve that issue.
Please read CONTRIBUTING.md, and then specifically improving a README.md. In short: the change should not be made to the README.md itself, but as a hint, and then the README.md should be regenerated.
TomPradat
force-pushed
the
docs/improve-resistor-color
branch
from
October 16, 2020 19:34
2723c77 to
5abdfb2
Compare
Contributor
Author
|
Yeap sorry i misread it. So i used the master version of the problem specifications, seems like there has been some changes. Do you want me to split my commit in two ? |
SleeplessByte
approved these changes
Oct 17, 2020
SleeplessByte
left a comment
Member
There was a problem hiding this comment.
Nah, because I'll squash merge it.
Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #833