Implement knapsack exercise - #1765
Conversation
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Currently implemented a recursive algorithm Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
|
Not sure why ParallelLetterFrequencyTest is failing in build and passing in build though I did not make any changes there. I'm currently not clear why this occurs even though I did not make any changes in that file. Any idea on what to do further? |
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
I think it has to do with an update today of gradle. We may need to reverse it or disable this test because it produces the following error: |
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
|
That's unfortunate, I'm sorry it's impacted your PR @sonapraneeth-a! I'd vote for removing the parallel-letter-frequency test. It's quite a complicated test that could easily confuse users and it's not based on any canonical data. What do you think @lemoncurry? 🙂 |
|
@FridaTveit I agree, it should be removed. |
|
I'll open a PR with it removed ASAP! 🙂 |
|
PR opened: #1766 🙂 |
|
How do I re-run the travis build once your PR is merged @FridaTveit ? |
|
@sonapraneeth-a you'll need to rebase your changes on master so that your branch has my PR on it. Here are some resources for that if you're not familiar with rebasing: |
|
@sonapraneeth-a I restarted the job 😄 The check is now successful. |
lemoncurry
left a comment
There was a problem hiding this comment.
@sonapraneeth-a Thank you for your contribution 😄
Concerning the algorithm you used to solve the exercise, I think there is improvement.
Otherwise only minor changes are necessary.
| "topics": [ | ||
| "algorithms", | ||
| "arrays", | ||
| "control_flow_loops" |
There was a problem hiding this comment.
This topic is not mentioned in the topics list.
Maybe there is another topic that might fit from the official list?
There was a problem hiding this comment.
Recursion and dynamic programming would be suitable topics. But none of them are present in the file shared.
| "slug": "knapsack", | ||
| "uuid": "ac179b77-98a5-4daf-9773-3d68b6cd8548", | ||
| "core": false, | ||
| "unlocked_by": null, |
There was a problem hiding this comment.
Could you please define an exercise that will unlock this one? e.g. saddle-points
There was a problem hiding this comment.
Currently using saddle-points to unlock knapsack
| @@ -0,0 +1,2 @@ | |||
| - Use recursion | |||
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
…erence Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
Signed-off-by: Sona Praneeth Akula <sonapraneeth.akula@gmail.com>
|
@lemoncurry , Please review. I've made necessary changes from my side. |
lemoncurry
left a comment
There was a problem hiding this comment.
LGTM, thank you @sonapraneeth-a !
Implementation of knapsack exercise.
Fixes #1747
Reviewer Resources:
Track Policies