This repository was archived by the owner on Jan 1, 2021. It is now read-only.
Using pkg_resource to make the package zip safe#20
Closed
Jonathan-Betts-RoS wants to merge 2 commits into
Closed
Conversation
added 2 commits
October 11, 2017 17:39
* Also marked as non-zip safe to be safe * This is because get_compiler_script() uses path concatentation
I can't currently get the tests to pass getting:
TypeError: Object function Object() { [native code] } has no method
'assign'
This is at least the same error I was getting before the commit
Owner
|
I included your change in #21. Thanks very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in addition to the previous change request (I branched from it), and this should make the package work even if people install it via "python setup.py install"