Skip to content

Fix deprecated method File.exists? to File.exist? - #159

Merged
knowtheory merged 2 commits into
documentcloud:masterfrom
tuttiq:master
Aug 31, 2024
Merged

Fix deprecated method File.exists? to File.exist?#159
knowtheory merged 2 commits into
documentcloud:masterfrom
tuttiq:master

Conversation

@tuttiq

@tuttiq tuttiq commented May 5, 2023

Copy link
Copy Markdown

Fix for this issue: #158

Fixes compatibility with ruby 3.2.

@tuttiq

tuttiq commented May 5, 2023

Copy link
Copy Markdown
Author

@knowtheory @jashkenas Any chance we get this merged?

@tmaier

tmaier commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

Hi, I just ran into the same issue when trying to upgrade to Ruby 3.2. It would be great, if this could get merged. It should also not break compatibility to < 3.2-versions.

@tsotne-m

tsotne-m commented Mar 4, 2024

Copy link
Copy Markdown

@tuttiq any news about this topic?
I just encountered this issue. Maybe you used alternative for gem and could you tell me which one?

@tuttiq

tuttiq commented Mar 4, 2024

Copy link
Copy Markdown
Author

@tsotne-m (cc @tmaier) I ended up pointing the source for the gem (on my project's Gemfile) to my forked version: https://github.com/tuttiq/docsplit

Not great, but I figured this repository is no longer being maintained 🤷‍♀️ I don't plan on maintaining my fork either (since I'm not working on that project anymore), so I recommend you maintain your own forks if you need this gem long term.

@tsotne-m

tsotne-m commented Mar 5, 2024

Copy link
Copy Markdown

@tuttiq Thanks a lot for response

@krystof-k

Copy link
Copy Markdown

I'm just working on getting rid of Docsplit as well and it depends on your usecase, but in my case of using it to extract word processing documents, it looks like switching to something like libreconv (or just LibreOffice directly) to convert the document to PDF and then use pdf-reader to extract the text is the way to go.

@tmaier

tmaier commented Mar 10, 2024

Copy link
Copy Markdown
Contributor

I consider to use Apache Tika in the future. Especially, a tika microservice.

It has a simple REST API to extract text. See https://cwiki.apache.org/confluence/display/TIKA/TikaServer#TikaServer-GettheTextofaDocument

@abratashov

Copy link
Copy Markdown

Why this PR isn't merged? This is a common issue for all +Ruby 3.2 projects...
CC: @jashkenas @anujaware

@knowtheory
knowtheory merged commit 67118b8 into documentcloud:master Aug 31, 2024
@abratashov

Copy link
Copy Markdown

❤️

@ckim2013

ckim2013 commented Nov 5, 2024

Copy link
Copy Markdown

have these changes been pushed to rubygems by any chance? as a workaround for our projects, we had to point the our gem to this repo's git directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants