Skip to content

Refactor binary-builder to support Ruby 3.x (cflinuxfs4) - #58

Merged
brayanhenao merged 1 commit into
mainfrom
binary-builder-refactor
Jul 22, 2022
Merged

Refactor binary-builder to support Ruby 3.x (cflinuxfs4)#58
brayanhenao merged 1 commit into
mainfrom
binary-builder-refactor

Conversation

@brayanhenao

Copy link
Copy Markdown
Contributor

No description provided.

@arjun024

Copy link
Copy Markdown
Member

@brayanhenao I'm not super familiar with the ruby world. So to clarify - not just certain modules and their functions are backwards incompatible, but the code itself written against ruby3.0 is backwards incompatible with ruby2.7?

I'm good with merging this to get the first dependencies built, but also wondering if there's a way to avoid double-maintenance until cflinuxfs3 goes out of support

@arjun024

Copy link
Copy Markdown
Member

@ryanmoran Any thoughts?

@arjun024
arjun024 requested a review from ryanmoran July 20, 2022 15:38
@brayanhenao

Copy link
Copy Markdown
Contributor Author

@arjun024

When I tried to run this code in cflinuxfs4 I started to get errors and when I corrected them another one appeared, so I decided to make a refactor.

The old code does not require much maintenance, as we do not change it constantly so I doubt that in 1 year (estimated for the deprecation of cflinuxfs3) it will require significant changes.

@brayanhenao
brayanhenao merged commit ff988e2 into main Jul 22, 2022
@brayanhenao
brayanhenao deleted the binary-builder-refactor branch July 22, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants