archive_recipe: compress tar with deference only for php - #57
Merged
Conversation
This makes the changes done in #56 to only affect php. We noticed undesired consequences in node and .Net and thus is only done in php until more details come to light.
sophiewigmore
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the changes done in #56 to only affect php.
We noticed undesired consequences in node and thus is only done in php for now.
As said in #56, the
--dereferenceflag replaces symlinks with their targets. This unfortunately assumes that any symlinkedexecutable would be portable and would not contain invocations of other files/executable via relative filepaths. This
assumption is not true for npm executable in the node dependency as shown in the following example.
In the case with
--dereference, when the npm executable is invoked, it fails withError: Cannot find module '../lib/utils/unsupported.js'because the now deferenced executable has lost the context of the relative path that should in reality point to/lib/node_modules/npm/bin/../lib/utils/<file>.js(cleaned path:lib/node_modules/npm/lib/utils/<file>.js)