-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat(input): OSC22 #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
natemoo-re
wants to merge
6
commits into
main
Choose a base branch
from
nm/feat/cursor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(input): OSC22 #101
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
edad10e
feat(input): parse OSC 22 pointer-shape replies into PointerShapeEvent
natemoo-re 9d12359
spec(renderer): add opt-in OSC 22 pointer-shape tracking (§12.6)
natemoo-re 6f6e0be
feat(term): opt-in OSC 22 pointer-shape tracking (renderer-spec §12.6)
natemoo-re 472e78b
example(keyboard): show a pointer cursor when hovering keys
natemoo-re 4b618f3
fix(term): use bare set OSC 22 so pointer shapes work on Ghostty
natemoo-re 637b954
fix(input): bail OSC code accumulation past 22 to prevent overflow
natemoo-re File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
fix(input): bail OSC code accumulation past 22 to prevent overflow
The numeric OSC code loop accumulated digits with no cap, so a long digit run (e.g. ESC ] 9999...) would overflow the int accumulator. Since 22 is the only code parse_osc accepts and the accumulator only grows, bail with PARSE_ERR as soon as it passes 22. Addresses review feedback from @dreyfus92 on #101.
- Loading branch information
commit 637b95437089cf3ba664840036eb2d07d445e088
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the loop accumulates digits with no cap before the
code != 22. feed itESC ] 99999999999...andcodeoverflows int. simplest guard is to clamp or bail inside the loop, e.g. break out oncecode > 22(or some small ceilling) since the only code you accept is 22 anyway anything is already aPARSE_ERR.