chore: a more polite closed issue message - #1954
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
|
Hi @kellertk, thanks for opening this PR. I'm going to put this on hold for now and will be following the discussion in aws-powertools/powertools-lambda-python#3671 before deciding whether to merge it or not since we share the same concerns expressed there. Also in the future please consider familiarizing yourself with the project's contribution guidelines, specifically around discussing changes in an issue before sending a PR. |
|
As discussed in the linked PR, we'll be refactoring our automations in the coming months and we'll take the opportunity to reword this message then. Thank you for opening this PR anyway. |

Description of your changes
In the AWS SDKs, we received some customer feedback that the closed issue message is too loud and too full of emoji. You use the same message. This message is slightly more polite. If you disagree, please discard this PR.
Related issues, RFCs
Issue number:
None
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.