chore: use DataFusion 55.0.0 from crates.io - #1695
Merged
Merged
Conversation
Now that DataFusion 55.0.0 is published to crates.io, remove the [patch.crates-io] entries that pointed at the 55.0.0-rc3 git tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — this is release follow-up maintenance, matching the equivalent change made for DataFusion 54 in #1588.
Rationale for this change
maincurrently pins the DataFusion crates to the55.0.0-rc3git tag via[patch.crates-io]. DataFusion 55.0.0 has since been published to crates.io, so the patch is no longer needed.The patch entries also block publishing:
dev/check_crates_patch.py(run by thecheck-crates-patchCI job) fails while any entries are present, since release builds must not depend on patched crates.What changes are included in this PR?
[patch.crates-io]entries fromCargo.toml. The section header and its explanatory comment are kept (an empty section is explicitly allowed bydev/check_crates_patch.py), so future development patches have an obvious home.Cargo.lockso the DataFusion crates resolve from the crates.io registry instead ofgit+https://github.com/apache/datafusion?rev=55.0.0-rc3.The declared dependency versions in
[workspace.dependencies]were already55.0.0, so no version numbers changed and no source changes were required.Are there any user-facing changes?
No. The resolved DataFusion version is unchanged — 55.0.0-rc3 and the 55.0.0 release are the same code, only the source moves from git to crates.io.