Skip to content

Allow users to share templates with Accounts or Projects through the #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulAngus merged 9 commits into from
Jul 18, 2019
Merged

Allow users to share templates with Accounts or Projects through the #3241

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b36eb37
Allow users to share templates with Accounts or Projects through the
Jan 16, 2019
0950b7f
Allow project id to be passed in even if no account name is specified
Apr 15, 2019
0fadb1d
Remove unused import
Jun 4, 2019
074e2ee
Fixed typo in capabilities key
Jun 10, 2019
4c219a5
Update dialogue layout and population logic for permissions of template
Jun 13, 2019
4facf03
Change behaviour to show only supported projects and accounts with up…
Jun 21, 2019
1555d31
Allow admins to see accounts dropdown and only hide lists for users
Jun 24, 2019
d383aa3
Fix bug for hover animation
Jun 24, 2019
e90bad4
Don't allow sharing project owned templates as you cannot retrieve th…
Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow admins to see accounts dropdown and only hide lists for users
  • Loading branch information
Anurag Awasthi
Anurag Awasthi committed Jul 12, 2019
commit 1555d317c0bff5d795b0f1e17c3dc0f2d6fd2ad1
2 changes: 1 addition & 1 deletion ui/scripts/sharedFunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var g_queryAsyncJobResultInterval = 3000;
var g_idpList = null;
var g_appendIdpDomain = false;
var g_sortKeyIsAscending = false;
var g_allowUserViewAllDomainAccounts= "false";
var g_allowUserViewAllDomainAccounts= false;

//keyboard keycode
var keycode_Enter = 13;
Expand Down
4 changes: 2 additions & 2 deletions ui/scripts/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,7 +1559,7 @@
// allow.user.view.domain.accounts = true
// Populate List of accounts in domain as dropdown multiselect
$form.find('[rel=sharewith]').css('display', 'inline-block');
if (g_allowUserViewAllDomainAccounts === true) {
if (!isUser() || g_allowUserViewAllDomainAccounts === true) {
$form.find('[rel=projects]').css('display', 'inline-block');
$form.find('[rel=accounts]').css('display', 'inline-block');
$form.find('[rel=accountlist]').hide();
Expand Down Expand Up @@ -1606,7 +1606,7 @@
} else {
// allow.user.view.domain.accounts = true
// Populate List of accounts in domain as dropdown multiselect
if (g_allowUserViewAllDomainAccounts === true) {
if (!isUser() || g_allowUserViewAllDomainAccounts === true) {
$form.find('[rel=projects]').hide();
$form.find('[rel=accountlist]').hide();
$form.find('[rel=accounts]').css('display', 'inline-block');
Expand Down