Skip to content

Fixed the default type of object that ODRBundleProvider supports - #95

Merged
timt-unity3d merged 1 commit into
Unity-Technologies:masterfrom
jwtan-unity:odr-provider-type-bug
Feb 6, 2025
Merged

Fixed the default type of object that ODRBundleProvider supports#95
timt-unity3d merged 1 commit into
Unity-Technologies:masterfrom
jwtan-unity:odr-provider-type-bug

Conversation

@jwtan-unity

Copy link
Copy Markdown
Contributor

GetDefaultType should return the inheritable base type (i.e. IAssetBundleResource) instead of the inherited type (i.e. ODRAssetBundleResource).

@timt-unity3d timt-unity3d left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM.

@timt-unity3d
timt-unity3d merged commit 9d48808 into Unity-Technologies:master Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants