Skip to content

Refactor Settings UI, improve build config, and fix startup features - #19

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
refactor-settings-ui-v2
Open

Refactor Settings UI, improve build config, and fix startup features#19
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
refactor-settings-ui-v2

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This PR addresses the user's feedback regarding the "ugly" settings window by providing a complete UI overhaul and ensures all requested features are functional and documented.

UI/UX Improvements:

  • Modern Settings Layout: Replaced the cluttered vertical list with a structured design.
    • GitHub Integration: Now a dedicated hero section. The "Personal Access Token" input and "Smart Connect" features are visually distinct yet cohesive.
    • Preferences: Grouped into a clean card with separated rows for "Check Interval", "Auto-Launch", and "Start Minimized".
  • Visual Polish: Added consistent icons (from lucide-react) to help users scan options quickly. Improved spacing, typography, and input styling using Shadcn/UI principles.
  • Feedback: Added save status indicators and hover effects.

Functional Fixes:

  • Startup Logic: The launchAtStartup setting is now enforced inside app.whenReady. This ensures that even if the setting was already true (e.g., default), the registry key is correctly updated/verified every time the app starts, which is crucial for portable apps moving locations.
  • Minimization: Confirmed startMinimized logic works by defaulting the window to hidden and only showing it if the setting is false.

Assets & Build:

  • Icon: Generated a custom geometric icon (electron/assets/icon.png).
  • Portable: Build config now outputs a portable .exe.
  • Docs: Updated README.md with high-quality screenshots generated via Playwright.

Verification:

  • Frontend verified with screenshots (visual check passed).
  • Build verified (TSC passed).

PR created automatically by Jules for task 17357167857423459411 started by @Javaec

- Completely redesigned `Settings.tsx` to use a modern, grid-based layout with distinct sections for "GitHub Integration" and "Application Preferences".
- Implemented "Settings Row" pattern for better alignment and readability.
- Added visual hierarchy with clear headers, icons, and card containers.
- Fixed "Launch at Startup" logic in `electron/main.ts` to ensure it is applied on application launch.
- Included necessary UI components (`Checkbox`, `Input`, `Label`) and dependencies (`lucide-react`, `@radix-ui/*`).
- Updated `README.md` with new screenshots reflecting the improved design.
- Configured "Portable" build target in `package.json`.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants