Skip to content

fix(shutdown): stop Ctrl+C output racing the shell prompt #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melvincarvalho wants to merge 1 commit into from
Closed

fix(shutdown): stop Ctrl+C output racing the shell prompt #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,15 +924,22 @@ jss.on('exit', (code) => {
}
});

// Graceful shutdown
// Graceful shutdown. The JSS child shares our process group, so a terminal
// Ctrl+C delivers SIGINT to it too — it prints its own "Shutting down..."
// and exits. Don't duplicate that line; wait for the child's actual exit
// before the farewell, so the output stays ordered ahead of the returning
// shell prompt instead of racing a fixed timeout against it.
process.on('SIGINT', () => {
console.log('\n' + chalk.yellow('⚠ Shutting down gracefully...'));
jss.kill('SIGTERM');
setTimeout(() => {
console.log(chalk.green('✓ Server stopped'));
console.log(chalk.dim('\nGoodbye! 👋\n'));
const farewell = () => {
console.log(chalk.green('\n✓ Server stopped'));
console.log(chalk.dim('Goodbye! 👋\n'));
process.exit(0);
}, 1000);
};
if (jss.exitCode !== null || jss.signalCode !== null) return farewell();
jss.once('exit', farewell);
jss.kill('SIGTERM');
// Safety net: don't hang if the child ignores SIGTERM.
setTimeout(() => { try { jss.kill('SIGKILL'); } catch {} }, 5000);
});

process.on('SIGTERM', () => {
Expand Down